RDKEMW-22860: Setting low latency properties on audio sink/decoder by Koky2701 · Pull Request #610 · rdkcentral/rialto

Koky2701 · 2026-09-28T15:33:37Z

Reason for change: Netflix needs low latency mode for NTS tests to pass. Idea is to add setting of low latency properties when 'immediate-output' is set, since it's one property which is available on each SOC Test Procedure: https://ccp.sys.comcast.net/browse/RDKEMW-22860

github-actions · 2026-09-28T15:33:48Z

Pull request title must follow the pattern:
< JIRA TICKET >: < one line summary of change less than 65 characters >

Pull request description must follow the Commit message format for RDK-E:
https://etwiki.sys.comcast.net/spaces/RDKAR/pages/1407997180/Commit+Message+Format+For+RDKE

Associated JIRA ticket in format : < JIRA TICKET >: < one line summary of change less than 65 characters >
Detailed reason for change information
Test procedure. Only references links to Jira ticket or sub tickets where test steps and references are captured.

< JIRA TICKET >: < one line summary of change less than 65 characters >
< empty line >
Reason for change:
Test Procedure: < https://ccp.sys.comcast.net/browse/JIRA TICKET/url/to/test_step_section>

Copilot

Copilot review overview

🟡 Changes recommended

Compilation, source-type handling, mock expectations, and the pending-state assertion must be corrected.

Review effort: Lite
Findings: 4

Open (4)

Missing getDecoder accessor causes compilation failure · New
Existing video test lacks expectations for new audio calls · New
Strict mock test misses getDecoder and getSink expectations · New
Test asserts pendingLowLatency without production assignment · New

What changed in this PR

This PR adds vendor-specific low-latency configuration for audio sinks and decoders when immediate output is enabled.

Changes:

Adds audio sink and decoder property handling.
Injects GStreamer/GLib wrappers into SetImmediateOutput.
Updates task construction and unit-test coverage.

File	Description
`tests/unittests/media/server/gstplayer/genericPlayer/tasksTests/SetImmediateOutputTest.cpp`	Adds audio immediate-output coverage.
`tests/unittests/media/server/gstplayer/genericPlayer/common/GenericTasksTestsBase.cpp`	Updates task construction and expectations.
`media/server/gstplayer/source/tasks/generic/SetImmediateOutput.cpp`	Implements audio latency property handling.
`media/server/gstplayer/source/tasks/generic/GenericPlayerTaskFactory.cpp`	Passes wrapper dependencies to the task.
`media/server/gstplayer/include/tasks/generic/SetImmediateOutput.h`	Extends task dependencies and state.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    GstElement *decoder = m_player.getDecoder(MediaSourceType::AUDIO);
+    if (decoder)


Copilot

Copilot review overview

🟡 Changes recommended

Critical runtime and test compilation issues remain, along with missing strict-mock expectations.

Review effort: Lite
Findings: 6

Open (6)

Defer decoder lookup until pipeline and elements are available · New
Fix test fixture access and qualify MediaSourceType · New
Test asserts pendingLowLatency without production assignment
Strict mock test misses getDecoder and getSink expectations
Existing video test lacks expectations for new audio calls
Missing getDecoder accessor causes compilation failure

+    GstElement *decoder = m_player.getDecoder(MediaSourceType::AUDIO);
+    if (decoder)


Copilot

Copilot review overview

🟡 Changes recommended

Critical test incompatibilities and functional issues remain in property naming, asynchronous setup handling, and unsupported source validation.

Review effort: Lite
Findings: 5 · 1 · 1

Open (7)

Update StrictMock tests for new audio traversal behavior · New
Fix test fixture access and qualify MediaSourceType
Defer decoder lookup until pipeline and elements are available
Strict mock test misses getDecoder and getSink expectations
Missing getDecoder accessor causes compilation failure
Use the canonical stream-sync-mode property name · New
Test audio vendor mappings and property values · New

Resolved since last review (2)

Test asserts pendingLowLatency without production assignment
Existing video test lacks expectations for new audio calls

+    GstElement *decoder = m_player.getDecoder(MediaSourceType::AUDIO);
+    if (decoder)
    {
-        m_context.pendingImmediateOutputForVideo = m_immediateOutput;
+        const auto setDecoderBoolPropertyIfExists = [&](const char *property, bool value) {
+            if (m_glibWrapper->gObjectClassFindProperty(G_OBJECT_GET_CLASS(decoder), property))


+        if (m_glibWrapper->gStrHasPrefix(decoderName.c_str(), "brcmaudiodecoder"))
+        {
+            setDecoderBoolPropertyIfExists("sync-off", m_immediateOutput);
+            setDecoderIntPropertyIfExists("stream_sync_mode", m_immediateOutput ? 1 : 0);


+TEST_F(SetImmediateOutputTest, shouldSetAudioImmediateOutput)
+{
+    shouldGetAudioElementsForImmediateOutput();
+    triggerAudioSetImmediateOutput();
+}


github-actions · 2026-09-29T09:38:43Z

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 85.0% to 84.8%
WARNING: Functions coverage decreased from: 93.4% to 93.3%

Reason for change: Netflix needs low latency mode for NTS tests to pass. Idea is to add setting of low latency properties when 'immediate-output' is set, since it's one property which is available on each SOC Test Procedure: https://ccp.sys.comcast.net/browse/RDKEMW-22860

github-advanced-security · 2026-10-05T20:53:32Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

Review effort: Lite
Findings: 5 · 5 · 3

Open (13)

The task is executed 'for %s source' based on m_type, but it always queries/configures AUDIO… · New
The task is executed 'for %s source' based on m_type, but it always queries/configures AUDIO… · New
Update StrictMock tests for new audio traversal behavior
Defer decoder lookup until pipeline and elements are available
Missing getDecoder accessor causes compilation failure
The contract text is inaccurate/unclear: it refers to 'getObjectUnref()' (no such API is shown… · New
getDecoder is a getter-style API but is non-const, unlike getSink(...) const and other query… · New
For AUDIO, the function neither persists a pending value in the context (unlike VIDEO) nor applies… · New
This new test only exercises the code path with getDecoder/getSink returning nullptr and doesn't… · New
Use the canonical stream-sync-mode property name
The boolean/int 'set property if exists' helpers are duplicated for decoder and sink. Consider… · New
The boolean/int 'set property if exists' helpers are duplicated for decoder and sink. Consider… · New
Test audio vendor mappings and property values

    RIALTO_SERVER_LOG_DEBUG("Executing SetImmediateOutput for %s source", common::convertMediaSourceType(m_type));

-    if (m_type == MediaSourceType::VIDEO)
+    GstElement *decoder = m_player.getDecoder(MediaSourceType::AUDIO);


+    GstElement *sink = m_player.getSink(MediaSourceType::AUDIO);
+    if (sink)
+    {


+     * @retval The decoder, NULL if not found. Please call getObjectUnref() if it's non-null
+     */
+    virtual GstElement *getDecoder(const MediaSourceType &mediaSourceType) = 0;


+     *
+     * @retval The decoder, NULL if not found. Please call getObjectUnref() if it's non-null
+     */
+    virtual GstElement *getDecoder(const MediaSourceType &mediaSourceType) = 0;


+    if (m_type == MediaSourceType::VIDEO)
+    {
+        m_context.pendingImmediateOutputForVideo = m_immediateOutput;
+        if (m_context.pipeline)
+        {
+            m_player.setImmediateOutput();
+        }
+        return;
    }

-    if (m_context.pipeline)
+    if (m_type != MediaSourceType::AUDIO)
    {
-        m_player.setImmediateOutput();
+        RIALTO_SERVER_LOG_ERROR("SetImmediateOutput not currently supported for source type %s",
+                                common::convertMediaSourceType(m_type));
    }


+TEST_F(SetImmediateOutputTest, shouldSetAudioImmediateOutput)
+{
+    shouldGetAudioElementsForImmediateOutput();
+    triggerAudioSetImmediateOutput();
+}


+        const auto setDecoderBoolPropertyIfExists = [&](const char *property, bool value) {
+            if (m_glibWrapper->gObjectClassFindProperty(G_OBJECT_GET_CLASS(decoder), property))
+            {
+                gboolean propertyValue{value ? TRUE : FALSE};
+                m_glibWrapper->gObjectSet(decoder, property, propertyValue, nullptr);
+            }
+        };
+
+        const auto setDecoderIntPropertyIfExists = [&](const char *property, gint value) {
+            if (m_glibWrapper->gObjectClassFindProperty(G_OBJECT_GET_CLASS(decoder), property))
+            {
+                m_glibWrapper->gObjectSet(decoder, property, value, nullptr);
+            }
+        };


+        const auto setBoolPropertyIfExists = [&](const char *property, bool value) {
+            if (m_glibWrapper->gObjectClassFindProperty(G_OBJECT_GET_CLASS(sink), property))
+            {
+                gboolean propertyValue{value ? TRUE : FALSE};
+                m_glibWrapper->gObjectSet(sink, property, propertyValue, nullptr);
+            }
+        };
+
+        const auto setIntPropertyIfExists = [&](const char *property, gint value) {
+            if (m_glibWrapper->gObjectClassFindProperty(G_OBJECT_GET_CLASS(sink), property))
+            {
+                m_glibWrapper->gObjectSet(sink, property, value, nullptr);
+            }
+        };


Copilot AI lite review requested due to automatic review settings September 28, 2026 15:33

Copilot started reviewing on behalf of Koky2701 September 28, 2026 15:34 View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 29, 2026 07:47

Koky2701 force-pushed the feature/RDKEMW-22860 branch from 46fcd33 to 90d9d11 Compare September 29, 2026 07:47

Copilot started reviewing on behalf of Koky2701 September 29, 2026 07:48 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 29, 2026 09:28

Koky2701 force-pushed the feature/RDKEMW-22860 branch from 90d9d11 to 9c58009 Compare September 29, 2026 09:28

Copilot started reviewing on behalf of Koky2701 September 29, 2026 09:29 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings October 5, 2026 20:47

Koky2701 force-pushed the feature/RDKEMW-22860 branch from 9c58009 to df03029 Compare October 5, 2026 20:47

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Navigation Menu

RDKEMW-22860: Setting low latency properties on audio sink/decoder - #610

RDKEMW-22860: Setting low latency properties on audio sink/decoder#610
Koky2701 wants to merge 1 commit into
masterfrom
feature/RDKEMW-22860

Koky2701 commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

github-advanced-security AI commented Oct 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		GstElement *decoder = m_player.getDecoder(MediaSourceType::AUDIO);
		if (decoder)

Conversation

Koky2701 commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

github-advanced-security AI commented Oct 5, 2026

What Enabling Code Scanning Means:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants