Single thread timer

[skywojciechowskim]

RDKEMW-24084: Single thread timer

Reason for change: Do not create a dedicated thread for each timer to improve the performance
Test Procedure: Rialto CI

[github-actions]

Pull request title must follow the pattern:
< JIRA TICKET >: < one line summary of change less than 65 characters >

Pull request description must follow the Commit message format for RDK-E:
https://etwiki.sys.comcast.net/spaces/RDKAR/pages/1407997180/Commit+Message+Format+For+RDKE

1. Associated JIRA ticket in format : < JIRA TICKET >: < one line summary of change less than 65 characters >
2. Detailed reason for change information
3. Test procedure. Only references links to Jira ticket or sub tickets where test steps and references are captured.

< JIRA TICKET >: < one line summary of change less than 65 characters >
< empty line >
Reason for change:
Test Procedure: < https://ccp.sys.comcast.net/browse/JIRA TICKET/url/to/test_step_section>

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved critical timer-ID race and additional context, compatibility, and dependency findings.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Synchronize timer source registration and ID publication · New

What changed in this PR

This PR replaces per-timer threads with a shared GLib timer-loop thread.

Changes:

• Adds shared one-shot and periodic GLib timer scheduling.
• Stores GLib source IDs instead of timer thread state.
• Updates build dependencies for GLib/GStreamer integration.

File	Summary and review status
common/​source/​Timer.cpp	Implements shared timer scheduling. Critical issue (2 votes): timer ID publication can race with callback dispatch. Moderate issues (1 vote each): use a private main context and address g_timeout_add_once GLib 2.74 compatibility.
common/​include/​Timer.h	Updates timer state to use GLib source identifiers.
common/​CMakeLists.txt	Adds build dependencies. Nit (1 vote): link directly to glib-2.0 instead of unrelated GStreamer modules.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 85.0% to 85.1%
Congratulations, your commit improved functions coverage from: 93.4% to 93.5%

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical callback-lifetime issue and multiple moderate correctness and dependency issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2

Open (2)

• Synchronize cancellation with in-flight timer callbacks · New
• Synchronize timer source registration and ID publication

Previously missed (2)

In code that hasn't changed since last review

Use a private GLib main context for timer sources

common/​source/​Timer.cpp:38

Passing nullptr selects GLib's process-wide default GMainContext, and both g_timeout_add calls below attach their sources to that same context. Running it from this worker can contend with or dispatch unrelated default-context sources, and timers may stop firing if another loop owns the context. Use a private context for the shared timer loop and attach each timer source to it.

Clear active state when one-shot timer fires

common/​source/​Timer.cpp:118

g_timeout_add_once removes the source after this callback, but m_active is never cleared here. Consequently every one-shot timer that fires naturally continues to report isActive() == true until someone explicitly calls cancel(), unlike the previous implementation (which set it false when the thread exited). Clear the active flag after the callback, including when the callback is empty.

[github-actions]

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 85.0% to 85.1%
Congratulations, your commit improved functions coverage from: 93.4% to 93.5%

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved timer initialization, lifecycle, cancellation, registration, and context-isolation issues block approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Uninitialized atomic timer ID can be read before assignment · New

Resolved since last review (2)

• Synchronize cancellation with in-flight timer callbacks
• Synchronize timer source registration and ID publication

Previously missed (1)

In code that hasn't changed since last review

One-shot timer remains active after expiration

common/​source/​Timer.cpp:140

A one-shot timer never transitions m_active to false when its source fires, so isActive() remains true after expiration. This also leaves the timer looking live to callers until destruction; clear the active state and remove the source ID independently of whether a callback is present.

[github-actions]

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 84.4% to 85.1%
Congratulations, your commit improved functions coverage from: 92.7% to 93.5%

[Copilot]

Copilot review overview

🟡 Changes recommended

Critical timer lifecycle and dispatch issues, plus callback, duration, and dependency concerns remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 · 1

Open (3)

• Use a private main context for timer dispatch · New
• Clear fired one-shot timer IDs before cancellation · New
• Handle empty callbacks without leaking active timer entries · New

Resolved since last review (1)

• Uninitialized atomic timer ID can be read before assignment

[github-actions]

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 85.0% to 85.1%
Congratulations, your commit improved functions coverage from: 93.4% to 93.5%

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved issues affect cancellation safety, timer cleanup, context ownership, and GLib compatibility.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Avoid requiring unavailable g_timeout_add_once API · New
• Preserve cross-thread cancellation synchronization · New
• Clear fired one-shot timer IDs before cancellation
• Use a private main context for timer dispatch
• Handle empty callbacks without leaking active timer entries

[github-actions]

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 85.0% to 85.1%
Congratulations, your commit improved functions coverage from: 93.4% to 93.5%

[Copilot]

Copilot review overview

🔵 Needs a closer look

Timer cancellation and callback state have unresolved safety and cleanup issues, and the build introduces an unnecessary client-side dependency.

Review effort: Lite
Findings: None

Resolved since last review (5)

• Preserve cross-thread cancellation synchronization
• Avoid requiring unavailable g_timeout_add_once API
• Clear fired one-shot timer IDs before cancellation
• Use a private main context for timer dispatch
• Handle empty callbacks without leaking active timer entries

[github-actions]

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.6%
Functions coverage stays unchanged and is: 92.8%