Wncxione 662 : Timer loop stuck

[DouglasAdler]

Reason for change: Fix a race condition where the process terminates
before the timer thread is started.
Test Procedure: Test using gst-inspect
Risks: None

[Copilot]

Copilot review overview

🟡 Changes recommended

Both Coverity workflows reference a nonexistent build.sh, and manual incremental runs lack a branch fallback.

Review effort: Lite
Findings: 2

Open (2)

• Full Coverity scan invokes nonexistent build.sh · New
• Incremental Coverity scan invokes nonexistent build.sh · New

What changed in this PR

This PR fixes timer shutdown synchronization, adds a quick-exit regression test, and introduces Coverity scanning workflows.

Changes:

• Reworks timer stop signaling and cleanup ordering.
• Adds repeated LD_PRELOAD quick-exit testing and Make targets.
• Adds incremental and full Coverity workflows.

File	Description
test/​timer_quick_exit_test.sh	Adds repeated quick-exit regression testing.
test/​Makefile	Adds the quick-exit test target.
rdkperf/​rdk_perf.cpp	Updates timer lifecycle and shutdown ordering.
Makefile	Exposes the top-level test target.
.github/​workflows/​coverity_incremental_scan.yml	Adds incremental Coverity scanning.
.github/​workflows/​coverity_full_scan.yml	Adds full Coverity scanning.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Pin reusable workflows, correct manual scan inputs, and propagate build failures before approval.

Review effort: Lite
Findings: 2

Open (2)

• Pin reusable workflow to an immutable commit · New
• Pin reusable workflow to an immutable commit · New

Resolved since last review (2)

• Incremental Coverity scan invokes nonexistent build.sh
• Full Coverity scan invokes nonexistent build.sh

Previously missed (1)

In code that hasn't changed since last review

Provide branch fallback for manually triggered scans

.github/​workflows/​coverity_incremental_scan.yml:20

On workflow_dispatch, github.event.pull_request is absent, so this expression passes an empty branchName to the reusable incremental-scan workflow even though pullRequestNumber is required for manual runs. Fall back to the selected workflow ref or add a branch input so manually triggered scans can resolve their base branch.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Four unresolved moderate findings affect branch selection and build-failure propagation.

Review effort: Lite
Findings: None

Resolved since last review (2)

• Pin reusable workflow to an immutable commit
• Pin reusable workflow to an immutable commit

Previously missed (3)

In code that hasn't changed since last review

Aggregate make target masks component build failures

.github/​workflows/​coverity_full_scan.yml:14

The Coverity job relies on make all, but the root target runs sub-makes in a shell loop whose exit status is only the final service make (Makefile:27-30); a failure in an earlier component can therefore be masked and the scan can proceed with an incomplete or stale build. Make the aggregate target fail fast (or invoke a fail-fast build wrapper) before using it here.

Manual workflow runs pass an empty base branch

.github/​workflows/​coverity_incremental_scan.yml:20

When this workflow is started via the declared workflow_dispatch trigger, github.event.pull_request does not exist, so this expression supplies an empty branchName to the reusable scan workflow. The manual-run path will therefore not know which base branch to scan; fall back to the ref used for the manual run (or add a branch input).

Aggregate make target masks component build failures

.github/​workflows/​coverity_incremental_scan.yml:22

The Coverity job relies on make all, but the root target runs sub-makes in a shell loop whose exit status is only the final service make (Makefile:27-30); a failure in an earlier component can therefore be masked and the scan can proceed with an incomplete or stale build. Make the aggregate target fail fast (or invoke a fail-fast build wrapper) before using it here.