Conversation
Reason for change: Infinite while loop runs when Task() is executed after StopTask() is called Test Procedure: Playback VIPA content multiple times and ensure that gst-scan hang is not seen Risks: low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The unsynchronized m_bContinue accesses leave a critical data race unresolved.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes a hang in the RDKPerf module when Task() runs after StopTask().
Changes:
- Adds an early stop-state check in
TimerCallback::Task(). - Synchronizes startup state inspection.
- Leaves
m_bContinueaccesses unsynchronized.
| File | Summary |
|---|---|
rdkperf/rdk_perf.cpp |
Updates timer task startup and early termination handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Reason for change: Infinite while loop runs when Task() is executed after StopTask() is called Test Procedure: Playback VIPA content multiple times and ensure that gst-scan hang is not seen Risks: low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
Reason for change: Infinite while loop runs when Task() is executed after StopTask() is called Test Procedure: Playback VIPA content multiple times and ensure that gst-scan hang is not seen Risks: low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
Reason for change: Infinite while loop runs when Task() is executed after StopTask() is called Test Procedure: Playback VIPA content multiple times and ensure that gst-scan hang is not seen Risks: low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Infinite while loop runs when Task() is executed after StopTask() is called
Test Procedure: Playback VIPA content multiple times and ensure that gst-scan hang is not seen
Risks: low