Fix/freewheel xhr location compliance

[vjain008]

No description provided.

[rdkcmf-jenkins]

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/rdkNativeScript/141/rdkcentral/rdkNativeScript

• Commit: 63db7f5

Report detail: gist'

[Copilot]

Pull request overview

This PR targets FreeWheel compatibility in the NativeScript JS runtime by making window.location values more browser-like and bringing the XMLHttpRequest polyfill closer to W3C event/property semantics, with added tests and diagnostic tooling to aid debugging.

Changes:

• Updated the XHR polyfill to add W3C properties (response, responseURL, timeout) and refine terminal event dispatch (load vs error/timeout/abort + loadend).
• Standardized window.location objects across runtime initialization paths to avoid malformed protocol + "//" + host values used by FreeWheel.
• Added new tests and documentation covering location encoding and XHR lifecycle expectations.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
utils/xhrdiagnostics.js	Adds an optional XHR lifecycle diagnostic logger (new utility).
utils/xhr.js	Enhances XHR polyfill with timeout/response properties and adjusted event semantics.
utils/window.js	Replaces minimal window.location stub with a fuller, FreeWheel-compatible shape; also re-indents existing code.
utils/location.js	Adds a location object factory for creating standardized location objects (new utility).
test/xhr.test.js	Adds a standalone test suite for XHR/location behavior and event dispatch expectations.
test/location-encoding.test.js	Adds encoding-focused tests for FreeWheel-style orig construction.
src/jsc/modules/windowwrapper.js	Updates JSC window wrapper location shape and syncs globalThis.location.
src/jsc/modules/linkedjsdomwrapper.js	Updates linked JSDOM wrapper location shape and syncs globalThis.location.
FREEWHEEL_FIX_SUMMARY.md	Adds a detailed write-up of the problem, root causes, and the implemented changes.

Suppressed comments (5)

utils/xhr.js:571

• The transport 'abort' handler always converts an abort into handleError(), which results in an 'error' event firing for intentional aborts/timeouts. It should ignore aborts once the XHR is already in a terminal state (sendFlag cleared / errorFlag set).

      if (typeof request.on === "function") {
        request.on("abort", function() {
          if (timeoutHandle) {
            clearTimeout(timeoutHandle);
            timeoutHandle = null;
          }
          self.handleError(new Error("XMLHttpRequest: request aborted by transport"));
        });
      }

utils/xhr.js:553

• The request-level error/abort handlers always call handleError(). When abort() or the timeout path aborts the underlying transport, these handlers can incorrectly dispatch an 'error' event (and an extra loadend) for what should be an abort/timeout terminal event.

      // Error handler for the request
      var errorHandler = function errorHandler(error) {
        if (timeoutHandle) {
          clearTimeout(timeoutHandle);
          timeoutHandle = null;
        }
        self.handleError(error);
      };

utils/xhr.js:599

• In the timeout path, request.abort() is called before sendFlag/errorFlag are updated. If the transport emits an 'abort' or 'error' event immediately, the request-level handlers can still call handleError() and dispatch an erroneous 'error' event in addition to 'timeout'.

      if (self.timeout > 0) {
        timeoutHandle = setTimeout(function() {
          if (sendFlag && request) {
            logDiag('timeout fired after ' + self.timeout + 'ms, aborting request');
            
            request.abort();
            request = null;
            sendFlag = false;
            
            self.status = 0;
            self.statusText = 'Timeout';
            self.responseText = '';
            self.response = '';
            errorFlag = true;

            setState(self.DONE);
            
            // Per W3C spec, dispatch timeout event
            self.dispatchEvent('timeout');
            // After timeout, must dispatch loadend
            self.dispatchEvent('loadend');
          }
        }, self.timeout);
      }

utils/xhr.js:665

• abort() calls request.abort() before setting sendFlag/errorFlag. If the transport emits 'abort'/'error' synchronously, the request-level handlers can still call handleError() and dispatch an 'error' event in addition to the intended abort/loadend events.

    if (request) {
      request.abort();
      request = null;
    }

utils/window.js:215

• Performance.clearMarks() iterates entries, but that identifier is not defined in this method (it was a local in mark()). This will throw and leave marks uncleared; use this.entries instead.

   clearMarks()
   {
     for (var key in entries)
     {
         entries[key] = null;

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.