Repository navigation
RDKMVE-3379: Vendor Component Verification and tag creations for M09 Release - #399
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Resolve the package version downgrade or use an explicit versioning mechanism.
Pull request overview
Updates vendor component source revisions and package versions for the M09 Raspberry Pi release.
Changes:
- Bumps eight vendor component
SRCREV/PVvalues. - Updates AppArmor vendor metadata.
File summaries
| File | Summary |
|---|---|
conf/include/vendor_pkg_versions.inc |
Updates vendor version pins. A PV downgrade from 2.0.1 to 1.0.1 may disrupt package upgrade handling. |
Review details
Suppressed comments (1)
conf/include/vendor_pkg_versions.inc:210
- This changes the package version from the previously published
2.0.1down to1.0.1while keepingPRatr0. Package managers and feed upgrade logic will treat the newly built component as older and may retain or reject it, even if the1.0.1tag is the intended source revision. Use a monotonically increasingPV(or an explicit epoch/versioning mechanism if this downgrade is deliberate).
PV:pn-iarmmgrs-hal-raspberrypi4 = "1.0.1"
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Keep the package version monotonic or define an explicit epoch transition before approval.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.