Skip to content

RDKB-67070 : In $_GET Skip empty segments and treat a missing '=' as an empty string value - #48

Open
pavankumar464 wants to merge 1 commit into
developfrom
bug/RDKB-67070
Open

pavankumar464 wants to merge 1 commit into
developfrom
bug/RDKB-67070

Conversation

@pavankumar464

@pavankumar464 pavankumar464 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Reason for change: Webui page with url "mac_ssid=&" and "mac_ssid" shows 500 Internal Server Error
Test Procedure: Test for mac_ssid URL inputs in wireless_network_configuration.jst
Risks: Low
Priority: P1

@pavankumar464
pavankumar464 requested a review from a team as a code owner September 28, 2026 03:16
Copilot AI lite review requested due to automatic review settings September 28, 2026 03:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Updates $_GET parsing to ignore empty query segments and treat parameters without = as empty strings, preventing 500 errors for inputs such as mac_ssid=& and mac_ssid.

Changes:

  • Updated runtime and test-prefix parsing.
  • Regenerated parser fixtures.
  • Added regression coverage.
File Description
tests/​parser/​jst_prefix.js Updated parser test prefix.
tests/​parser/​jst_parser_template_block_string.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_template_block_content.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_skip_whitespace.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_single_quotes.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_line_feeds.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_unknown.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_runtime.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_once.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_not_if_in_line_comment.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_not_if_in_content.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_not_if_in_block_comment.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_nested.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_malformed_1.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_code_before.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_include_code_after.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_comment_tag.jst.parsed Regenerated parser output.
tests/​parser/​jst_parser_backslash.jst.parsed Regenerated parser output.
tests/​parser_test.cpp Added regression tests.
jsts/​jst_prefix.js Updated runtime $_GET parsing.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants