RDKB-67070 : In $_GET Skip empty segments and treat a missing '=' as an empty string value - #48
Open
pavankumar464 wants to merge 1 commit into
Open
pavankumar464 wants to merge 1 commit into
pavankumar464 wants to merge 1 commit into
Conversation
…an empty string value
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates $_GET parsing to ignore empty query segments and treat parameters without = as empty strings, preventing 500 errors for inputs such as mac_ssid=& and mac_ssid.
Changes:
- Updated runtime and test-prefix parsing.
- Regenerated parser fixtures.
- Added regression coverage.
| File | Description |
|---|---|
tests/parser/jst_prefix.js |
Updated parser test prefix. |
tests/parser/jst_parser_template_block_string.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_template_block_content.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_skip_whitespace.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_single_quotes.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_line_feeds.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_unknown.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_runtime.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_once.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_not_if_in_line_comment.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_not_if_in_content.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_not_if_in_block_comment.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_nested.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_malformed_1.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_code_before.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_include_code_after.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_comment_tag.jst.parsed |
Regenerated parser output. |
tests/parser/jst_parser_backslash.jst.parsed |
Regenerated parser output. |
tests/parser_test.cpp |
Added regression tests. |
jsts/jst_prefix.js |
Updated runtime $_GET parsing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Webui page with url "mac_ssid=&" and "mac_ssid" shows 500 Internal Server Error
Test Procedure: Test for mac_ssid URL inputs in wireless_network_configuration.jst
Risks: Low
Priority: P1