RDKB-66901 : Updated parsers in GET, POST, and file metadata - #45
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The file metadata regression test does not exercise the first-delimiter behavior.
Pull request overview
Updates JST GET, POST, and file metadata parsing to preserve values containing =.
Changes:
- Split request fields at the first
=delimiter. - Add regression coverage and prefix-path configuration.
- Refresh generated parser fixtures.
Review note: The file metadata regression test uses config%3Dbackup, so it does not verify the new behavior. It should use literal config=backup.
File summaries
| File | Summary |
|---|---|
tests/parser/jst_prefix.js |
Updated parser prefix fixture. |
tests/parser/jst_parser_template_block_string.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_template_block_content.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_skip_whitespace.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_single_quotes.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_line_feeds.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_unknown.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_runtime.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_once.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_not_if_in_line_comment.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_not_if_in_content.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_not_if_in_block_comment.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_nested.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_malformed_1.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_code_before.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_include_code_after.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_comment_tag.jst.parsed |
Refreshed generated parser output. |
tests/parser/jst_parser_backslash.jst.parsed |
Refreshed generated parser output. |
tests/parser_test.cpp |
Added request parsing regression coverage. |
tests/CMakeLists.txt |
Configured the runtime prefix path for tests. |
jsts/jst_prefix.js |
Updated GET, POST, and file metadata parsing. |
Review details
Suppressed comments (1)
tests/parser_test.cpp:303
- This fixture percent-encodes the file name (
config%3Dbackup), so the pre-changesplit('=')implementation would also decode it successfully and the test does not exercise the new first-delimiter behavior.source/jst_post.cserializes file metadata without URL-encoding, so use a literalconfig=backuphere to catch the regression for real multipart metadata.
"id=file1&name=config%3Dbackup&type=application%2Foctet-stream");
- Files reviewed: 21/21 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hpatel006c
previously approved these changes
Sep 16, 2026
GoutamD2905
previously approved these changes
Sep 17, 2026
pavankumar464
dismissed stale reviews from GoutamD2905 and hpatel006c
via
September 17, 2026 04:35
5916277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fix GET, POST, and file metadata parsing
Test Procedure: Test for UI actions
Risks: Low
Priority: P1