Skip to content

RDKB-66901 : Updated parsers in GET, POST, and file metadata - #45

Merged
GoutamD2905 merged 2 commits into
developfrom
bug/RDKB-66901
Sep 17, 2026
Merged

GoutamD2905 merged 2 commits into
developfrom
bug/RDKB-66901

Conversation

@pavankumar464

Copy link
Copy Markdown
Contributor

Reason for change: Fix GET, POST, and file metadata parsing
Test Procedure: Test for UI actions
Risks: Low
Priority: P1

Copilot AI lite review requested due to automatic review settings September 16, 2026 12:12
@pavankumar464
pavankumar464 requested a review from a team as a code owner September 16, 2026 12:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The file metadata regression test does not exercise the first-delimiter behavior.

Pull request overview

Updates JST GET, POST, and file metadata parsing to preserve values containing =.

Changes:

  • Split request fields at the first = delimiter.
  • Add regression coverage and prefix-path configuration.
  • Refresh generated parser fixtures.

Review note: The file metadata regression test uses config%3Dbackup, so it does not verify the new behavior. It should use literal config=backup.

File summaries
File Summary
tests/parser/jst_prefix.js Updated parser prefix fixture.
tests/parser/jst_parser_template_block_string.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_template_block_content.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_skip_whitespace.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_single_quotes.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_line_feeds.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_unknown.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_runtime.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_once.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_not_if_in_line_comment.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_not_if_in_content.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_not_if_in_block_comment.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_nested.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_malformed_1.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_code_before.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_include_code_after.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_comment_tag.jst.parsed Refreshed generated parser output.
tests/parser/jst_parser_backslash.jst.parsed Refreshed generated parser output.
tests/parser_test.cpp Added request parsing regression coverage.
tests/CMakeLists.txt Configured the runtime prefix path for tests.
jsts/jst_prefix.js Updated GET, POST, and file metadata parsing.
Review details

Suppressed comments (1)

tests/parser_test.cpp:303

  • This fixture percent-encodes the file name (config%3Dbackup), so the pre-change split('=') implementation would also decode it successfully and the test does not exercise the new first-delimiter behavior. source/jst_post.c serializes file metadata without URL-encoding, so use a literal config=backup here to catch the regression for real multipart metadata.
      "id=file1&name=config%3Dbackup&type=application%2Foctet-stream");
  • Files reviewed: 21/21 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

hpatel006c
hpatel006c previously approved these changes Sep 16, 2026
GoutamD2905
GoutamD2905 previously approved these changes Sep 17, 2026
Copilot AI review requested due to automatic review settings September 17, 2026 04:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Runtime changes are consistent and covered by a focused regression test.

Review details
  • Files reviewed: 20/20 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@GoutamD2905
GoutamD2905 merged commit a98f252 into develop Sep 17, 2026
16 of 17 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 17, 2026
@pavankumar464
pavankumar464 deleted the bug/RDKB-66901 branch September 17, 2026 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants