RDKB-66901 : Updated parser to preserve additional characters in GET, POST and file metadata

[pavankumar464]

Reason for change: Webui Wi-Fi page 500 Internal Error
Test Procedure: Test Webui actions
Risks: Low
Priority: P1

[Copilot]

🔵 Needs a closer look

Unescaped & and ; in metadata can still corrupt $_FILES.

Pull request overview

Updates JST request parsing to preserve = characters in GET, POST, and file metadata.

Changes:

• Parse key/value pairs using the first = delimiter.
• Synchronize parser fixtures and regenerate expected outputs.

File summaries

File	Summary
tests/parser/jst_prefix.js	Synchronizes the parser prefix fixture.
tests/parser/jst_parser_template_block_string.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_template_block_content.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_skip_whitespace.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_single_quotes.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_line_feeds.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_unknown.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_runtime.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_once.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_not_if_in_line_comment.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_not_if_in_content.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_not_if_in_block_comment.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_nested.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_malformed_1.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_code_before.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_include_code_after.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_comment_tag.jst.parsed	Regenerates parser output.
tests/parser/jst_parser_backslash.jst.parsed	Regenerates parser output.
jsts/jst_prefix.js	Updates request parsing; metadata delimiter handling remains unresolved.

Review details

Suppressed comments (1)

jsts/jst_prefix.js:225

• These splits still treat & and ; as unconditional delimiters, but source/jst_post.c:770-776 serializes the multipart filename and other metadata into this string without escaping them. A valid filename such as a&b.txt or a;b.txt is therefore split into extra records and $_FILES is corrupted; encode the metadata when producing the record (and decode it here), or use an unambiguous serialization format.

      var eqIdx = fileData[j].indexOf('=');
      if(eqIdx != -1)
      {
        if(!fileId)
        {
          fileId = decodeURIComponent(fileData[j].substring(eqIdx + 1));
          $_FILES[fileId]={};
        }
        else
        {
          $_FILES[fileId][decodeURIComponent(fileData[j].substring(0, eqIdx))]=decodeURIComponent(fileData[j].substring(eqIdx + 1));

• Files reviewed: 19/19 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The new /var/video_analytics/ lookup path is not accompanied by moving or installing the parser assets, which may cause template loading failures.

Get a fresh assessment by requesting another Copilot review.

Review details

• Files reviewed: 20/20 changed files
• Comments generated: 1
• Review effort level: Lite