Skip to content

RDKB-66802 : Fix invalid session handling #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pavankumar464 wants to merge 15 commits into from
Closed

RDKB-66802 : Fix invalid session handling #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b4fbe73
RDKB-66802 : Fix invalid session handling
pavankumar464 Sep 4, 2026
28fbb8c
Merge branch 'develop' into bug/session-issue
pavankumar464 Sep 4, 2026
a6fe439
Apply batched suggestions from code review
pavankumar464 Sep 6, 2026
0f83099
Fix session_start and session_create return handling
pavankumar464 Sep 6, 2026
f4efadc
Prevent stale session proxy persistence
pavankumar464 Sep 6, 2026
126d31b
Adding isSecure request scheme detection tests
pavankumar464 Sep 6, 2026
3a20adf
test(session): cover wrapper session lifecycle and secure cookie hand…
pavankumar464 Sep 7, 2026
0ac8913
fix(session): expire logout cookie and validate DUKSID boundaries
pavankumar464 Sep 14, 2026
43186bd
revalidate stale sessions and fix parser test path
pavankumar464 Sep 15, 2026
8e2cc6c
test(session): assert no cookie on failed session start
pavankumar464 Sep 16, 2026
6b3d368
fix(session): prevent stale proxies writing replacement sessions
pavankumar464 Sep 16, 2026
5dcfe40
test(parser): regenerate prefix golden fixtures
pavankumar464 Sep 16, 2026
6cb039b
fix(session): persist empty sessions before revalidation
pavankumar464 Sep 16, 2026
bd50b74
fix(session): restrict backing file permissions
pavankumar464 Sep 16, 2026
78652d2
session handling
pavankumar464 Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 87 additions & 45 deletions jsts/jst_prefix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,69 +89,102 @@ var $_SERVER = new Proxy({}, {
var $_SESSION = {};
var $_jst_session = null;
var $_val_input = {};
function session_start()
function _jst_session_cookie()
{
if($_jst_session)
return;
if($_val_input == 1)
{
$_val_input = 0;
return;
}
ccsp_session.start();
var host = getenv('HTTPS');
if (host == false)
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
else
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; secure" + "; httponly";
header($cookie);
$_jst_session = ccsp_session.getData();
$_SESSION = new Proxy($_jst_session, {
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
if(ccsp_session.isSecure())
$cookie += "; secure";
return $cookie;
}
function _jst_expire_session_cookie()
{
var $cookie = "Set-Cookie: DUKSID=; Max-Age=0; httponly";
if(ccsp_session.isSecure())
$cookie += "; secure";
return $cookie;
}
function _jst_session_is_current($session_id)
{
if(!ccsp_session.getStatus() || ccsp_session.getId() !== $session_id)
return false;

if(ccsp_session.start() && ccsp_session.getId() === $session_id)
return true;

$_jst_session = null;
$_SESSION = {};
return false;
}
function _jst_session_proxy($session)
{
var $session_id = ccsp_session.getId();
return new Proxy($session, {
get: function(obj, prop) {
return obj[prop];
},
set: function(obj, prop, val){
obj[prop] = val;
ccsp_session.setData(obj);
if(_jst_session_is_current($session_id))
ccsp_session.setData(obj);
return true;
},
deleteProperty(obj, prop) {
if(prop in obj)
{
delete obj[prop];
ccsp_session.setData(obj);
if(_jst_session_is_current($session_id))
ccsp_session.setData(obj);
}
return true;
}
});
}
function session_start()
{
if($_jst_session)
{
if(ccsp_session.start())
Comment thread
pavankumar464 marked this conversation as resolved.
return true;
Comment thread
pavankumar464 marked this conversation as resolved.

$_jst_session = null;
$_SESSION = {};
return false;
}
if($_val_input == 1)
{
$_val_input = 0;
return false;
}
if(!ccsp_session.start())
{
/* A stale cookie must not create a proxy backed by an inactive session. */
$_jst_session = null;
$_SESSION = {};
return false;
}
if(ccsp_session.getStatus())
{
header(_jst_session_cookie());
}
$_jst_session = ccsp_session.getData();
if($_jst_session === null || typeof($_jst_session) !== 'object')
$_jst_session = {};
$_SESSION = _jst_session_proxy($_jst_session);
return true;
}
function session_create(){
ccsp_session.create();
var host = getenv('HTTPS');
if (host == false)
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
else
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; secure" + "; httponly";
header($cookie);
if(!ccsp_session.create())
{
$_jst_session = null;
$_SESSION = {};
return false;
}
Comment on lines +176 to +181
header(_jst_session_cookie());
$_jst_session = ccsp_session.getData();
$_SESSION = new Proxy($_jst_session, {
get: function(obj, prop) {
return obj[prop];
},
set: function(obj, prop, val){
obj[prop] = val;
ccsp_session.setData(obj);
return true;
},
deleteProperty(obj, prop) {
if(prop in obj)
{
delete obj[prop];
ccsp_session.setData(obj);
}
return true;
}
});
if($_jst_session === null || typeof($_jst_session) !== 'object')
$_jst_session = {};
$_SESSION = _jst_session_proxy($_jst_session);
return true;
}
function session_id()
{
Expand All @@ -163,14 +196,23 @@ function session_status()
}
function session_destroy()
{
header(_jst_expire_session_cookie());
delete $_jst_session;
$_jst_session = null;
delete $_SESSION;
$_SESSION = {};
return ccsp_session.destroy();
}
function session_unset()
{//FIXME
{
var $session_id = ccsp_session.getId();
if(!$_jst_session || !_jst_session_is_current($session_id))
return false;

for(var $key in $_jst_session)
delete $_jst_session[$key];

return ccsp_session.setData($_jst_session);
}
function session_print()
{
Expand Down
Loading
Loading