Repository navigation
Conversation
…y source paths (#31) Reason for change: Address PRs native builds failing in the javascript-templates Test Procedure: PRs native builds should pass for javascript-templates Risks: Low Priority: P2 --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
RDKB-65597 : [Risk-High] Fixing JST (Generic) Security Fuzzing Report Reason for change: Root Cause: ftell() causing calloc() to request an enormous allocation and trigger an OOM abort. Recommendation - Check `ftell()` return value for `-1` before using it as allocation size: Root Cause: `strtok()` on const/env Memory Recommendation - Replace destructive strtok() parsing with read-only boundary detection using strchr(), copy the session ID into a local writable buffer, and use that buffer for validation and file lookup. Root Cause: Session identifier validation can be bypassed, potentially allowing session hijacking. Recommendation - Check Session IDs length and prefix, it should contain only alphanumeric suffix characters, avoid in-place cookie modification during parsing, and are accepted only if the corresponding session file exists. Test Procedure: WebGUI should work as expected Risks: Medium Priority: P1 --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Reason for change: Fix session ID format before handling Test Procedure: Test for session identifier Risks: High Priority: P1
Fixed Heap Buffer Overflow in `do_openssl_verify_with_cert` Recommendation - Check `strlen(filepath) >= 7` before calling `memcmp`, or use `strncmp` which handles short strings safely Fixed Command Injection via `popen()` Recommendation - Never pass untrusted input to `popen()` — use `execve()` with argument arrays or sanitize input --------- Co-authored-by: anoopchelakkode <65686868+anoopchelakkode@users.noreply.github.com>
|
📋 PR Format Reminder
Expected: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.9.0