LTE-2939- Added code improvements to prevent SSL_write crash

[annie-rashmitha]

No description provided.

[Copilot]

Copilot review overview

🟡 Changes recommended

Successful debug-mode sends are incorrectly logged and returned as failures.

Review effort: Balanced
Findings: 1

Open (1)

• Debug build reports successful send as SSL_write failure · New

What changed in this PR

Adds synchronized SSL writes and connection teardown to prevent SSL_write crashes.

Changes:

• Introduces a mutex-protected SSL write helper.
• Migrates message and file-transfer writes to the helper.
• Synchronizes SSL shutdown and resource cleanup.

File	Description
Idm_TCP_apis.h	Declares the safe SSL write API.
Idm_TCP_apis.c	Implements synchronized writes and teardown.
Idm_msg_process.c	Uses connection-aware safe writes for file-transfer responses.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Blocking TLS shutdown can stall all device communication, and the write API narrows lengths without validation.

Review effort: Balanced
Findings: 1 · 1

Open (2)

• Blocking SSL shutdown can stall device writes and configuration access · New
• Successful debug sends are logged at error severity · New

Resolved since last review (1)

• Debug build reports successful send as SSL_write failure

Previously missed (1)

In code that hasn't changed since last review

size_t payload length can overflow SSL_write's int parameter

source/​InterDeviceManager/​Idm_TCP_apis.c:88

payload_len is exposed as size_t but is unconditionally narrowed to the int length accepted by SSL_write. Values above INT_MAX are converted to an invalid/truncated length, so this API cannot safely honor its declared input range. Reject lengths above INT_MAX (and include <limits.h>) or change the API to use a bounded integer type.

[Copilot]

Copilot review overview

🟡 Changes recommended

Global locking can stall all peers, while multi-write file transactions can still be interleaved and corrupted.

Review effort: Balanced
Findings: 2

Open (2)

• Lock release between metadata and body corrupts framing · New
• Blocking SSL shutdown can stall device writes and configuration access

Resolved since last review (1)

• Successful debug sends are logged at error severity