Conversation
Reason for change: Remove reading FR value while updating local device variables Test Procedure: Check IDM DML values Risks: Low Signed-off-by: biju.vijayanindiradevi@sky.uk
Reason for change: Remove reading FR value while updating local device variables Test Procedure: Check IDM DML values Risks: Low Signed-off-by: biju.vijayanindiradevi@sky.uk
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change matches the stated purpose and introduces no apparent behavioral or compilation issues.
Review effort: Lite
Findings: None
What changed in this PR
Removes factory-default capability reads when updating local device capabilities, keeping updates based on current PSM/runtime values.
Changes:
- Removes factory-default fallback from add-capabilities handling.
- Removes factory-default fallback from remove-capabilities handling.
| File | Description |
|---|---|
source/InterDeviceManager/Idm_rbus.c |
Eliminates factory-value reads during capability updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove reading FR value while updating local device variables
Test Procedure: Check IDM DML values
Risks: Low
Signed-off-by: biju.vijayanindiradevi@sky.uk