RDKB-65626: Prevent invalid hotspot command execution - #70
Merged
Merged
Conversation
Reason for change: Initialize the hotspot command buffer and execute it only when commands were appended. This prevents stale Buffer 2 contents from being passed to the shell when hotspot bridges are managed through CORE_NET_LIB. Test Procedure: Hotspot should be running with no new error. Risks: Medium Priority: P1 Signed-off-by: Sriraaman C <sriraaman33@gmail.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing CORE_NET_LIB unit tests must be updated to validate the new command-execution behavior.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prevents stale command-buffer contents from being executed during CORE_NET_LIB bridge configuration.
Changes:
- Zero-initializes the command buffer.
- Executes shell commands only when commands were appended.
| File | Description |
|---|---|
source/HotspotApi/HotspotApi.c |
Guards hotspot command execution against empty buffers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bunnam988
approved these changes
Sep 30, 2026
apattu200
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Initialize the hotspot command buffer and execute it only when commands were appended.
This prevents stale Buffer 2 contents from being passed to the shell when hotspot bridges are managed through CORE_NET_LIB.
Test Procedure: Hotspot should be running with no new error.
Risks: Medium
Priority: P1