Conversation
Add validation for portName before using as persistence key to prevent injection attacks from whitespace and control characters. Add security regression test to validate port name checking logic.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Author
|
Ready for Review All required CI checks have completed successfully for the current head SHA:
The PR is mergeable and ready for human review. Parent Story: RDKEMW-25465 |
Remove unnecessary NULL checks on char array (portName) to address Coverity warning. The array is always non-NULL, so only strlen check is needed. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
Addressed Coverity warnings by removing unnecessary NULL checks on char array. The field is a char array, not a pointer, so the NULL checks were unnecessary. Removed them to address the Coverity false positives while preserving the strlen validation. |
Author
|
This has been addressed in the latest commit (902db1a). The NULL checks on char array have been removed. |
1 similar comment
Author
|
This has been addressed in the latest commit (902db1a). The NULL checks on char array have been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for portName before using as persistence key to prevent injection attacks from whitespace and control characters.
Changes
Testing
Parent Story: RDKEMW-25465