RDKB-67106: Remove legacy ipv4/ipv6 sysevent handling - #36
Merged
Merged
Conversation
Reason for change: Remove the legacy ipv4/ipv6 operational status sysevent handling which is overriding the eRouter mode based on operational state. Test Procedure: Validate the eRouter mode remains with default Dualstack mode unless explicitly modified Risks: High Priority: P0 Signed-off-by: Sivaraj_Sivalingam@comcast.com
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Preserve the finished provisioning-state transition without changing eRouter mode.
Review effort: Lite
Findings: None
What changed in this PR
This PR removes legacy IPv4/IPv6 sysevent handling that could alter eRouter mode during gateway provisioning.
Changes:
- Removes legacy status events and subscriptions.
- Deletes IPv4/IPv6 operational-mode transition handlers.
- Retains supported WAN address event processing.
An unresolved moderate issue remains: successful dual-stack acquisition may leave provisioning permanently IN_PROGRESS.
| File | Description |
|---|---|
source/CMAgentSsp/gw_prov_sm.c |
Removes legacy IPv4/IPv6 sysevent processing from the provisioning state machine. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sivaraj-comcast
changed the title
hpatel006c
approved these changes
Sep 25, 2026
snayak002c
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove the legacy ipv4/ipv6 sysevent handling from GwProv flow since it modifies the eRTR mode based on the ipv4/ipv6 operational status.
Test Procedure: Validate RF loss / restore scenario keep the device is Dualstack mode and both ipv4/v6 addresses obtained.
Risks: High
Priority: P0
Signed-off-by: Sivaraj_Sivalingam@comcast.com