Skip to content

Fix assert on unknown packageType when ralfpack is not used - #49

Merged
astolcenburg merged 1 commit into
rdkcentral:mainfrom
astolcenburg:main
Aug 19, 2026
Merged

astolcenburg merged 1 commit into
rdkcentral:mainfrom
astolcenburg:main

Conversation

@astolcenburg

Copy link
Copy Markdown
Contributor

Ref: #RDKEAPPRT-936

Copilot AI lite review requested due to automatic review settings August 18, 2026 20:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a strict assertion around packageType when generating the OCI artifact manifest in the non-ralfpack packaging path, preventing failures for unknown (or newly introduced) package types while keeping the manifest/layer format consistent with the current EROFS+dm-verity packaging flow.

Changes:

  • Stop passing config.packageType into makeArtifactManifest() and remove the layer mediaType override in pack.cjs.
  • Simplify makeArtifactManifest() by removing the packageType→filename mapping and the corresponding assert, and make the layer mediaType consistently erofs+dmverity.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
bolt/src/pack.cjs Removes reliance on config.packageType for manifest generation and relies on the manifest builder’s default layer media type.
bolt/src/artifact-manifest.cjs Removes the packageType switch/assert and standardizes the layer media type to EROFS+dm-verity.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@astolcenburg
astolcenburg merged commit 6270d23 into rdkcentral:main Aug 19, 2026
4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants