Accept package configs with any packageType value - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Bolt package config validation to align with the referenced spec change by accepting any string packageType, making entryPoint mandatory, and making versionName optional. This affects how pack validates configs and adds a warning path for unknown package types.
Changes:
- Relaxed package config validation to accept any string
packageTypeand requireentryPoint. - Centralized config validation in
pack.cjsviaPackageConfig.validate. - Added
PackageConfig.isKnownPackageType()and a warning inpack.cjsfor unknownpackageTypevalues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bolt/src/PackageConfig.cjs | Updates validation rules and introduces known-packageType detection. |
| bolt/src/pack.cjs | Switches to shared config validation and warns on unknown packageType. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This also changes package config validation to match the specification: - entryPoint is considered mandatory - versionName is optional Ref: #RDKEAPPRT-936
ansu-mathew
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also changes package config validation to match the specification:
Ref: #RDKEAPPRT-936