Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Generated deserialization does not preserve unset optional vector elements, causing the new tests to fail or assert.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds COM-RPC functional coverage for std::vector marshalling.
Changes:
- Adds vector interfaces, implementations, and tests.
- Covers primitive, structured, nested, and optional vectors.
- Registers and documents the new test suite.
| File | Description |
|---|---|
tests/FunctionalTests/README.md |
Documents the suite. |
tests/FunctionalTests/CMakeLists.txt |
Adds the test option. |
tests/FunctionalTests/comrpc/CMakeLists.txt |
Registers vector tests. |
tests/FunctionalTests/comrpc/tests/TestVectors.cpp |
Adds COM-RPC test cases. |
tests/FunctionalTests/common/CMakeLists.txt |
Registers the interface and implementation. |
tests/FunctionalTests/common/interfaces/README.md |
Documents vector coverage. |
tests/FunctionalTests/common/interfaces/ITestVectors.h |
Defines the test interface. |
tests/FunctionalTests/common/interfaces/Ids.h |
Assigns the interface ID. |
tests/FunctionalTests/common/implementations/TestVectorsImpl.cpp |
Implements test behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+63
to
+65
| virtual Core::hresult SummarizeOptionalElements(const std::vector<Core::OptionalType<uint32_t>>& values /* @in @restrict:0..255 */, uint32_t& valueSum /* @out */, uint32_t& setCount /* @out */) const = 0; | ||
| virtual Core::hresult GetOptionalElements(std::vector<Core::OptionalType<uint32_t>>& values /* @out @restrict:0..255 */) const = 0; | ||
| virtual Core::hresult TransformOptionalElements(std::vector<Core::OptionalType<uint32_t>>& values /* @inout @restrict:0..255 */) const = 0; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.