Skip to content

[StubGen] Fix optional vectors (#323) - #324

Merged
sebaszm merged 1 commit into
R4_4from
development/fix-opt-vector
Aug 25, 2026
Merged

sebaszm merged 1 commit into
R4_4from
development/fix-opt-vector

Conversation

@sebaszm

@sebaszm sebaszm commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 25, 2026 06:22
@sebaszm sebaszm added the 4.4 label Aug 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes optional std::vector serialization and deserialization in stub/proxy generation.

Changes:

  • Uses temporary storage for optional vectors.
  • Clears non-optional output vectors before population.
  • Resets optional outputs when values are absent.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

@github-actions

Copy link
Copy Markdown

JsonGenerator Results

View Results

No changes detected.

@github-actions

Copy link
Copy Markdown

ProxyStubGenerator Results

View Results

Changes detected.

@sebaszm
sebaszm merged commit edbe95b into R4_4 Aug 25, 2026
73 checks passed
@sebaszm
sebaszm deleted the development/fix-opt-vector branch August 25, 2026 11:56
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants