Remove obsolete code - #364
Merged
Merged
Conversation
sebaszm
requested review from
MFransen69
and
a balanced review from Copilot
September 30, 2026 10:19
MFransen69
previously approved these changes
Sep 30, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Root build options, CI flags, and current documentation still reference the deleted components.
Review effort: Balanced
Findings: 1
What changed in this PR
Removes the obsolete Bluetooth audio sink/source client libraries and sample tools.
Changes:
- Removes both Bluetooth audio libraries and public C APIs.
- Removes example player/recorder tools.
- Stops adding their source directories to the build.
| File | Description |
|---|---|
Source/CMakeLists.txt |
Removes Bluetooth audio subdirectories. |
Source/bluetoothaudiosource/Module.h |
Removes source module definitions. |
Source/bluetoothaudiosource/Module.cpp |
Removes source module declaration. |
Source/bluetoothaudiosource/include/bluetoothaudiosource.h |
Removes the source C API. |
Source/bluetoothaudiosource/CMakeLists.txt |
Removes source build configuration. |
Source/bluetoothaudiosource/btaudiorecorder/readme.txt |
Removes recorder documentation. |
Source/bluetoothaudiosource/btaudiorecorder/main.c |
Removes the recorder tool. |
Source/bluetoothaudiosource/btaudiorecorder/CMakeLists.txt |
Removes recorder build configuration. |
Source/bluetoothaudiosource/BluetoothAudioSource.cpp |
Removes source client implementation. |
Source/bluetoothaudiosink/Module.h |
Removes sink module definitions. |
Source/bluetoothaudiosink/Module.cpp |
Removes sink module declaration. |
Source/bluetoothaudiosink/include/bluetoothaudiosink.h |
Removes the sink C API. |
Source/bluetoothaudiosink/CMakeLists.txt |
Removes sink build configuration. |
Source/bluetoothaudiosink/btaudioplayer/readme.txt |
Removes player documentation. |
Source/bluetoothaudiosink/btaudioplayer/main.c |
Removes the player tool. |
Source/bluetoothaudiosink/btaudioplayer/CMakeLists.txt |
Removes player build configuration. |
Source/bluetoothaudiosink/BluetoothAudioSink.cpp |
Removes sink client implementation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MFransen69
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.