Skip to content

RDKEMW-26108: Authenticate OCDM endpoints - #357

Open
andrejz2 wants to merge 3 commits into
masterfrom
topic/RDKEMW-26108
Open

RDKEMW-26108: Authenticate OCDM endpoints#357
andrejz2 wants to merge 3 commits into
masterfrom
topic/RDKEMW-26108

Conversation

@andrejz2

@andrejz2 andrejz2 commented Sep 30, 2026

Copy link
Copy Markdown

Summary

  • verify OCDM endpoint type, ownership, and access mode before accessor creation
  • fail closed when endpoint trust requirements are not met
  • add executable endpoint trust-boundary coverage

Tracking

  • Jira: RDKEMW-26108
  • Parent: RDKEMW-25943

Verification

  • focused endpoint test compiled and passed locally
  • whitespace validation passed
  • full component build deferred to CI

azerom960 @devin-ai-integration azerom960
RDKEMW-26108: authenticate OCDM endpoints
95a0023 
Reject non-local, incorrectly owned, and writable IPC endpoints before creating the OCDM accessor.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 03:32
Copilot AI reviewed Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 30, 2026
View reviewed changes
Comment thread Source/ocdm/test_endpoint_validation.cpp Fixed
azerom960 @devin-ai-integration azerom960
RDKEMW-26108: Address security scan feedback
f067826 
Avoid broad test socket permissions while preserving endpoint validation coverage.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 04:03
Copilot AI reviewed Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

azerom960 @devin-ai-integration azerom960
RDKEMW-26108: Restore cross-platform endpoint build
dcd4d8e 
Keep endpoint validation platform-specific while preserving the Windows loopback contract.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 04:31
Copilot AI reviewed Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@andrejz2

andrejz2 commented Sep 30, 2026

Copy link
Copy Markdown
Author

Follow-up complete for current head dcd4d8e230c3443d82e67f1f4b9bebbdc2126137. Automated feedback was addressed and all current-head checks completed successfully. The complete defensive diff received final security review and is ready for human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrejz2 @github-advanced-security