Skip to content

RDKEMW-26106: Enforce bounds in OCDM metadata parsing - #347

Open
andrejz2 wants to merge 4 commits into
masterfrom
topic/RDKEMW-26106
Open

RDKEMW-26106: Enforce bounds in OCDM metadata parsing#347
andrejz2 wants to merge 4 commits into
masterfrom
topic/RDKEMW-26106

Conversation

@andrejz2

@andrejz2 andrejz2 commented Sep 29, 2026

Copy link
Copy Markdown

Summary

  • enforce structural and arithmetic bounds for OCDM subsample metadata
  • share validation across supported adapter entry points
  • add executable boundary coverage for valid and rejected metadata

Tracking

  • Jira: RDKEMW-26106
  • Parent: RDKEMW-25943

Verification

  • focused parser boundary test compiled and passed locally
  • whitespace validation passed
  • full CMake verification deferred because CMake is unavailable in the local environment

azerom960 @devin-ai-integration azerom960
RDKEMW-26106: enforce CENC metadata bounds
c6bfb45 
Centralize subsample validation across OCDM adapter entry points and add executable boundary coverage.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 29, 2026 20:31
Copilot AI reviewed Sep 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

azerom960 @devin-ai-integration azerom960
RDKEMW-26106: cover empty metadata boundaries
f84c5c5 
Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 29, 2026 20:42
Copilot AI reviewed Sep 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

azerom960 @devin-ai-integration azerom960
RDKEMW-26106: reject inconsistent adapter metadata
9d5db64 
Fail closed on mismatched subsample state and missing required key buffers before adapter sinks.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 29, 2026 20:52
Copilot AI reviewed Sep 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@andrejz2

andrejz2 commented Sep 30, 2026

Copy link
Copy Markdown
Author

Follow-up complete for current head 9d5db64bef8731a56e5da18791f165008679a86d. Automated feedback has no actionable remediation request, and all current-head checks completed successfully. The complete defensive diff received final security review and is ready for human review.

azerom960 @devin-ai-integration azerom960
RDKEMW-26106: Harden malformed metadata cleanup
82f0519 
Only unmap successfully mapped subsample buffers and cover the maximum supported count boundary.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 04:50
Copilot AI reviewed Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@andrejz2

andrejz2 commented Sep 30, 2026

Copy link
Copy Markdown
Author

Follow-up complete for current head 82f0519f14fda7888f417e353f87c37c38d0e305. Automated feedback was addressed and all current-head checks completed successfully. The complete defensive diff received final security review and is ready for human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrejz2