Skip to content

feat : RDKEMW-24274-Backport Firebolt AppActions Feature to Ripple - #952

Merged
kvfasil merged 3 commits into
3.3.1.rcfrom
RDKEMW-24274-To-3.3.1
Sep 29, 2026
Merged

kvfasil merged 3 commits into
3.3.1.rcfrom
RDKEMW-24274-To-3.3.1

Conversation

@Vinodsathyaseelan

Copy link
Copy Markdown
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

…acquisitions.

A concurrent Actions.intent call could observe a new intent with the old ID or vice versa.
Fixed by combining both updates into a single apps.write() lock block in new_active_session().
Copilot AI lite review requested due to automatic review settings September 28, 2026 19:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Manivannan1802
Manivannan1802 requested a review from a team September 29, 2026 14:37
Copilot AI lite review requested due to automatic review settings September 29, 2026 17:22
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
core.sdk.src.api.manifest 74% ➖
core.sdk.src.service.mock_app_gw 0% ❌
core.main.src.utils 30% ❌
core.sdk.src.service 65% ➖
core.tdk.src.gateway 100% ✔
device.thunder_ripple_sdk.src.processors.events 0% ❌
device.thunder_ripple_sdk.src.processors 19% ❌
core.main.src.bootstrap 0% ❌
core.sdk.src.manifest 0% ❌
device.thunder_ripple_sdk.src.bootstrap 0% ❌
core.main.src.bootstrap.extn 0% ❌
device.thunder_ripple_sdk.src.client 61% ➖
core.sdk.src.extn 76% ✔
core.main.src.state.cap 42% ❌
core.main.src 0% ❌
core.main.src.broker.thunder 37% ❌
core.sdk.src.api.device 77% ✔
core.sdk.src.service.mock_app_gw.appgw 0% ❌
core.sdk.src.utils 58% ➖
device.thunder_ripple_sdk.src.events 4% ❌
core.tdk.src.utils 0% ❌
core.main.src.service.ripple_service 9% ❌
core.main.src.broker 69% ➖
core.sdk.src.api.distributor 29% ❌
core.main.src.service.extn 25% ❌
core.main.src.state 35% ❌
core.sdk.src.api.firebolt 85% ✔
core.sdk.src.framework 64% ➖
device.mock_device.src 56% ➖
core.sdk.src.api.gateway 69% ➖
core.sdk.src.extn.ffi 0% ❌
device.thunder_ripple_sdk.src 13% ❌
core.main.src.broker.test 90% ✔
core.main.src.processor 0% ❌
core.main.src.service 32% ❌
core.sdk.src.processor 9% ❌
core.main.src.service.apps 29% ❌
core.main.src.firebolt.handlers 13% ❌
core.main.src.bootstrap.manifest 0% ❌
core.sdk.src.api 45% ❌
core.sdk.src.extn.client 81% ✔
core.sdk.src.api.observability 57% ➖
core.main.src.broker.rules 78% ✔
core.main.src.firebolt 12% ❌
core.main.src.processor.storage 0% ❌
Summary 49% (21718 / 44024) ➖

Minimum allowed line rate is 48%

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical unsupported API exposure and additional intent response and lifecycle delivery issues remain unresolved.

Review effort: Lite
Findings: 2 High severity

Open (2)

Comment thread core/main/src/firebolt/handlers/actions_rpc.rs
Comment thread examples/reference-manifest/IpStb/firebolt-device-manifest.json
@kvfasil
kvfasil merged commit 8ab5236 into 3.3.1.rc Sep 29, 2026
9 checks passed
@kvfasil
kvfasil deleted the RDKEMW-24274-To-3.3.1 branch September 29, 2026 17:27
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants