Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
DML AP-MLD updates regress, and MLD MAC generation mishandles octet overflow.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Enables MLO for Banana Pi EasyMesh backhaul VAPs and adds the required 6 GHz interfaces.
Changes:
- Assigns mesh backhaul VAPs to MLD group 1.
- Adds
mld1, 6 GHz backhaul, and IoT interfaces. - Rejects zero MLD/BSSID addresses and removes duplicate translation logic.
| File | Description |
|---|---|
source/webconfig/wifi_easymesh_translator.c |
Updates MLD MAC validation and translation flow. |
source/db/wifi_db.c |
Enables default backhaul MLO configuration. |
source/db/wifi_db_apis.c |
Mirrors backhaul MLO defaults in DB APIs. |
config/openwrt/banana-pi/wifi_interface_up.sh |
Creates and configures added interfaces. |
config/openwrt/banana-pi/wifi_interface_down.sh |
Tears down added interfaces. |
config/openwrt/banana-pi/InterfaceMap.json |
Maps backhaul links to mld1. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
🔎 clang-tidy (advisory)🔎 clang-tidy advisory — 1 findings |
Contributor
🔨 Build summaryCommit Banana Pi R4 - MLO — build success
|
Reason for change: Added mld1 interface for enabling backhaul MLO. Also enabled 6GHz iot and mesh_backhaul VAPs in OpenWRT build. - Treat an all-zero MLD/BSSID as invalid in fill_ap_mld_info_from_vap to avoid reporting a bogus valid MAC. - Drop the now-unused mesh-STA/AP-MLD-info branch (and its dead `ret`) from translate_vap_object_to_easymesh_for_dml, superseded by translate_vap_object_to_easymesh_bss_info. Test Procedure: Ensure BE mode enabled for backhaul vaps and extender connections works in MLO. Risks: Medium Priority: P1 Signed-off-by: Rakhil P E <rakhilpe001@gmail.com>
rakhilpe
force-pushed
the
enable_mlo_backhaul
branch
from
October 1, 2026 10:13
d72df14 to
17a4798
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Persisted configurations are not migrated, and the standard OpenWRT package replaces the updated interface map with an outdated variant.
Review effort: Balanced
Findings: 1
Open (2)
Resolved since last review (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKBWIFI-349: Easymesh - Enable MLO for all backhaul VAPs
Reason for change: Added mld1 interface for enabling backhaul MLO. Also enabled 6GHz iot and mesh_backhaul VAPs in OpenWRT build.
ret) from translate_vap_object_to_easymesh_for_dml, superseded by translate_vap_object_to_easymesh_bss_info.Test Procedure: Ensure BE mode enabled for backhaul vaps and extender connections works in MLO.
Risks: Medium
Priority: P1