RDKEMW-23662: Exclude dirs for cov scan - #488
Open
Sonajeya31 wants to merge 5 commits into
Open
Sonajeya31 wants to merge 5 commits into
Sonajeya31 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Excluding required libocispec sources causes CMake configuration to fail.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Filters non-product directories from the source tree used for Coverity scan builds.
Changes:
- Creates an external filtered source tree.
- Excludes selected directories before configuring and building Dobby.
| File | Description |
|---|---|
cov_build.sh |
Prepares and builds from a filtered source tree. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+26
to
+31
| ! -name 'libocispec' \ | ||
| ! -name 'develop' \ | ||
| ! -name 'openspec' \ | ||
| -exec cp -a {} "${COV_BUILD_SOURCE}/" \; | ||
|
|
||
| echo "DEBUG: excluded directories: .git .cov_build_source build tests libocispec develop openspec; keeping install for dependency resolution" |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR change/fix and why?
Exclude directories that are not needed for coverity scan
If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.
Test Procedure
Check for the issues in cov scan
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)