RDKEMW-25196: Harden force-stop to SIGKILL the whole container cgroup - #474
Merged
Merged
Conversation
DobbyManager::stopContainer(cd, withPrejudice=true) only sent SIGKILL to the container's tracked init process, not the whole cgroup, and trusted that the runc CLI call succeeding meant the container was actually dead. If a crashed/hung process left orphaned descendants that init can't reap, or a process is stuck in an uninterruptible sleep, the container could be left running indefinitely with no indication the force-stop failed. Add DobbyManager::forceKillContainerAndVerify(), used by both force-kill paths in stopContainer(), which sends SIGKILL via killCont(..., all=true) and polls DobbyRunC::state() for up to ~500ms to confirm the container actually stopped, logging clearly and returning false if it didn't. Add L1 tests covering both the all=true behaviour and the case where the container stays Running after SIGKILL. Update the daemon-core spec to document the new behaviour.
ks734
changed the title
B-Larsen
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DobbyManager::stopContainer(cd, withPrejudice=true) only sent SIGKILL to the container's tracked init process, not the whole cgroup, and trusted that the runc CLI call succeeding meant the container was actually dead. If a crashed/hung process left orphaned descendants that init can't reap, or a process is stuck in an uninterruptible sleep, the container could be left running indefinitely with no indication the force-stop failed.
Add DobbyManager::forceKillContainerAndVerify(), used by both force-kill paths in stopContainer(), which sends SIGKILL via killCont(..., all=true) and polls DobbyRunC::state() for up to ~500ms to confirm the container actually stopped, logging clearly and returning false if it didn't.
Add L1 tests covering both the all=true behaviour and the case where the container stays Running after SIGKILL. Update the daemon-core spec to document the new behaviour.
Description
What does this PR change/fix and why?
If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.
Test Procedure
How to test this PR (if applicable)
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)