Conversation
* RDKEMW-21185: Add exitcode on container stopped event * RDKEMW-21185: Add exitcode on container stopped event * Adding tests for container stopped events * Adding tests for container stopped events
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges Develop into Main and introduces exit-code propagation for container stopped events by adding a new StoppedWithStatus signal pathway in DobbyProxy, plus accompanying L1 unit tests and L2 integration tests.
Changes:
- Add a new status-aware listener API (
registerListenerWithStatus) to receive container stop events with an exit code. - Subscribe to and dispatch a new
StoppedWithStatussignal, extracting exit code from rawwaitpidstatus. - Add L1 (GTest) and L2 (dbus-monitor-based) tests plus a new container spec used to force an exit code.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/L2_testing/test_runner/runner.py | Registers the new L2 exit-code test module in the test runner. |
| tests/L2_testing/test_runner/exit_code_tests.py | Adds L2 integration tests validating StoppedWithStatus emission and exit-code encoding. |
| tests/L2_testing/dobby_specs/exit_with_code.json | Adds a container spec that exits with a known code (42) for L2 validation. |
| tests/L1_testing/tests/DobbyProxyTest/DobbyProxyTests.cpp | Adds L1 unit tests for the new status-listener API and event parsing/dispatch behavior. |
| tests/L1_testing/tests/DobbyProxyTest/CMakeLists.txt | Adds build rules for the new DobbyProxy L1 test executable. |
| tests/L1_testing/tests/CMakeLists.txt | Includes the new DobbyProxyTest subdirectory in the L1 test build. |
| tests/L1_testing/mocks/IIpcServiceMock.h | Extends the IPC service mock with isServiceAvailable used by DobbyProxy. |
| tests/L1_testing/mocks/IIpcServiceMock.cpp | Implements the new IIpcService::isServiceAvailable mock shim method. |
| tests/L1_testing/mocks/IIpcService.h | Extends the IPC service interface with isServiceAvailable. |
| client/lib/source/DobbyProxy.cpp | Subscribes to StoppedWithStatus, parses raw status, and dispatches to status listeners with exit code. |
| client/lib/include/DobbyProxy.h | Adds status listener API and extends internal event representation to carry exitCode. |
| AppInfrastructure/Public/Dobby/IDobbyProxy.h | Extends the public proxy interface with a status-listener type and registration methods. |
Suppressed comments (1)
tests/L2_testing/test_runner/exit_code_tests.py:159
- The extract_int32_args() docstring says it returns tuples, but the function actually returns a list of dicts (with keys descriptor/name/raw_status). Update the docstring to match the real return type to avoid confusion.
Returns a list of (descriptor, name, raw_status) tuples for each match.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pkumbh631
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-21185: Add exitcode on container stopped event
RDKEMW-21185: Add exitcode on container stopped event
Adding tests for container stopped events
Adding tests for container stopped events
Description
What does this PR change/fix and why?
If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.
Test Procedure
How to test this PR (if applicable)
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)