Conversation
… yocto4 and yocto5 Reason for change: modifying argument parsing to handle escaped and unescaped @ separators consistently Test: generate the bundle , check the args alignment in config.json Risks: None Signed-off-by: ssiras826 <ssiras826@cable.comcast.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new parsing mishandles quoted whitespace, drops empty arguments, and lacks focused tests.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates OCI argument parsing for Yocto 4 and Yocto 5 separator formats.
Changes:
- Supports escaped and unescaped
@separators. - Rebuilds the process argument list before adding DobbyInit.
| File | Description |
|---|---|
bundlegen/core/bundle_processor.py |
Updates OCI process argument conversion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+468
to
+470
| item = item.replace(r'\@', '@') | ||
| if '@' in item: | ||
| parts = item.split('@') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: modifying argument parsing to handle escaped and unescaped @ separators consistently
Test: generate the bundle , check the args alignment in config.json
Risks: None