Skip to content

fix: mobile dialogs and single-chain Frontier rendering - #7

Merged
rayalexvector merged 3 commits into
mainfrom
fix/mobile-ui-20261008
Oct 7, 2026
Merged

rayalexvector merged 3 commits into
mainfrom
fix/mobile-ui-20261008

Conversation

@rayalexvector

Copy link
Copy Markdown
Owner

Scope

  • Add accessible modal semantics, background isolation, focus containment/restoration, touch-sized closing controls and scrollable short-screen content.
  • Keep portrait-only game behavior while allowing an existing dialog to remain usable after rotation.
  • Remove the document-wide double-tap handler that swallowed fast taps on different controls; preserve CSS touch constraints.
  • Cancel Frontier animation frames on pause/background/state changes and prevent duplicate loops after rapid resume. Preserve visual quality and homepage content.

Verification

  • 81 Node tests passed before final browser fixes; focused modal/lifecycle tests and static checks passed afterward.
  • Actual mobile modal interaction passed at 320x568, 390x844 and 844x390, including touch scroll, focus and explicit resume.
  • Extended browser tests cover real Frontier touch movement, background stop and exactly one update chain.
  • Full browser suite runs locally and under the required verify check before merge.

Boundaries

No production data edits, model calls, paid services or homepage redesign. Chromium emulation does not replace physical iOS Safari and VoiceOver acceptance.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T20:12:59.649401Z 797ee1a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 797ee1abd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread arcade/js/ui.js
const top = modalStack[modalStack.length - 1];
for (const node of document.body.children) {
if (!inertState.has(node)) inertState.set(node, node.inert);
node.inert = top ? node !== top.backdrop : inertState.get(node);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid inerting an open native save dialog

When a game’s save manager is open and the page is backgrounded and restored, cloud-save.js has an open native dialog.showModal() while the visibility handler in app.js opens the custom pause modal. This assignment makes that native dialog inert, but it remains in the browser top layer above the ordinary .modal-backdrop, leaving touch users unable to interact with either dialog and effectively requiring a reload. Preserve an open top-layer dialog or defer the pause modal until the save dialog closes.

Useful? React with 👍 / 👎.

@rayalexvector

Copy link
Copy Markdown
Owner Author

Follow-up regression found and fixed: a completed no-op cloud pull could emit a progress-replacement event while a newer local play counter update was pending, returning Frontier to its menu. Added a deterministic failing-then-passing transaction regression and retained notification for actual remote replacement. Rapid resume now queues the next frame rather than rendering synchronously for every toggle. Static cache v4 refreshes the shared core for historical SW clients. Current local results: 82 frontend tests and 48 backend integration/runtime tests passed. Full browser checks are rerunning for the final commit.

@rayalexvector
rayalexvector merged commit 5ab5a33 into main Oct 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant