This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Refactor to use yarl package for safe URL manipulation#74
Open
rapsealk wants to merge 3 commits into
Open
Conversation
Author
|
Hi @waleedkadous! Would you mind if I ask for a review? Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello llmperf!
This pull request suggests to use
yarl, which is already included, to manipulate URL safely.The change in this pull request,
yarl.URL(address).with_path("/chat/completions"), will always result in a valid URL, whether theaddressends with a trailing slash(/) or not.Thanks in advance for your kind review!
Ref