Repository navigation
Retain managed model states between text generation runs - #13
Merged
Merged
Conversation
rattus128
force-pushed
the
dev/persistent-model-state-review
branch
from
November 9, 2026 07:50
4313df7 to
b1913ef
Compare
rattus128
force-pushed
the
dev/persistent-model-state-review
branch
from
November 9, 2026 12:19
b1913ef to
156e544
Compare
rattus128
marked this pull request as ready for review
November 9, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
SaveModelState.writethroughdefaults to true; false defers persistence until lifecycle writeback and is not crash-durable while pending.Persistence only. Batched continuation and long-prompt prefill remain in #12. Both PRs independently target
prs/qwen35-kv-chat; neither depends on the other. No dependency or cache-capacity changes. All tests remain in the final commit.Validation
qwen3.5_9b_w4a8g16_int8_head_embed_mtp.safetensorsworkflows passed: immediate/deferred saves on the 5080 with graphs enabled; deferred saves on the 5060 with graphs disabled. Covered recall, matching branch outputs, and continuation after explicit model unload.The new GPU validation is Windows-only and uses the 9B checkpoint; earlier 27B results are not claimed as a rerun of this revision.