Added fix for filterable check in query - #35
Open
kevinmeijer97 wants to merge 2 commits into
Open
Conversation
BobWez98
approved these changes
Aug 19, 2026
| $query = $model::with('attributeOptions'); | ||
|
|
||
| // Pick the correct filter strategy for the configured model. | ||
| if (is_a($model, QueryBuilderProductAttribute::class, true)) { |
Member
There was a problem hiding this comment.
is_a can return true even when $model is an empty object, i think instanceof would be better here because that also checks if it really is a "object"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
ProductAttributeControllerto avoid calling the upstreamfilterable()scope when the project uses a differentProductAttributemodel, falling back to the correctcatalog_eav_attributebased filter.