Changed slideover to popover and dialog #46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import "invokers-polyfill" | ||
|
|
||
| if (!(typeof HTMLElement !== 'undefined' && typeof HTMLElement.prototype === 'object' && 'popover' in HTMLElement.prototype)) | ||
| { | ||
| function replacePopovers(baseElement) { | ||
| function replacePopover(el, newCommand) { | ||
| let target = el.getAttribute('popovertarget') ?? el.getAttribute('commandfor') | ||
| el.removeAttribute('popovertargetaction') | ||
| el.removeAttribute('popovertarget') | ||
| el.setAttribute('commandfor', target) | ||
| el.setAttribute('command', newCommand) | ||
| } | ||
|
|
||
| baseElement.querySelectorAll('[command=show-popover]').forEach(el => el.command = 'show-modal') | ||
| baseElement.querySelectorAll('[command=toggle-popover]').forEach(el => el.command = 'show-modal') | ||
| baseElement.querySelectorAll('[command=hide-popover]').forEach(el => el.command = 'close') | ||
|
|
||
| baseElement.querySelectorAll('[popovertargetaction=show]').forEach(el => replacePopover(el, 'show-modal')) | ||
| baseElement.querySelectorAll('[popovertargetaction=toggle]').forEach(el => replacePopover(el, 'show-modal')) | ||
| baseElement.querySelectorAll('[popovertargetaction=hide]').forEach(el => replacePopover(el, 'close')) | ||
| } | ||
|
|
||
| replacePopovers(document) | ||
|
|
||
| const observer = new MutationObserver((mutations) => { | ||
| if (mutations.some((mutation) => | ||
| mutation.target.hasAttribute('popovertargetaction') | ||
| || mutation.target.hasAttribute('popovertarget') | ||
| || mutation.target.hasAttribute('commandfor') | ||
| )) { | ||
| replacePopovers(mutation.target.parentElement ?? document) | ||
| } | ||
| }) | ||
|
|
||
| observer.observe(document, { | ||
| attributes: true, | ||
| childList: true, | ||
| subtree: true, | ||
| attributeFilter: ['popovertargetaction', 'popovertarget', 'command'] | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <button {{ $attributes->twMerge('shrink-0 cursor-pointer hover:opacity-75') }}> | ||
| <x-heroicon-o-arrow-left class="size-6" /> | ||
| </button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <button {{ $attributes->twMerge('shrink-0 cursor-pointer hover:opacity-75 absolute right-5 top-1/2 -translate-y-1/2') }}> | ||
| <x-heroicon-o-x-mark class="size-7" /> | ||
| </button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <div {{ $attributes->twMerge('p-5 overflow-y-auto max-h-full') }}> | ||
| {{ $slot }} | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <div {{ $attributes->twMerge('p-5 flex gap-x-4')}}> | ||
| {{ $slot }} | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <div {{ $attributes->twMerge('p-5 bg-primary text-primary-text flex gap-x-4 items-center text-center justify-center text-lg relative') }}> | ||
| {{ $slot }} | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <x-rapidez::slideover.content :attributes="$attributes->twMerge('lg:contents')"> | ||
| {{ $slot }} | ||
| </x-rapidez::slideover.content> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <x-rapidez::slideover.footer :attributes="$attributes->twMerge('lg:hidden')"> | ||
| {{ $slot }} | ||
| </x-rapidez::slideover.footer> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <x-rapidez::slideover.header :attributes="$attributes->twMerge('lg:hidden')"> | ||
| {{ $slot }} | ||
| </x-rapidez::slideover.header> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| {{-- | ||
| This mobile version shows content on desktop and hides it within a slideover on mobile resolution. | ||
|
|
||
| ## Behavior | ||
| - On mobile: Functions as a regular slideover | ||
| - On desktop: Content is displayed directly on the page | ||
| - Button should be hidden on desktop using `lg:hidden` | ||
|
|
||
| ## Example | ||
| ```blade | ||
| <button commandfor="example" command="show-modal" class="lg:hidden"> | ||
| Open Mobile Slideover | ||
| </button> | ||
|
|
||
| <x-rapidez::slideover.mobile id="example" closedby="any"> | ||
| <x-rapidez::slideover.mobile.header> | ||
| Title | ||
| <x-rapidez::slideover.close commandfor="example" command="show-modal" /> | ||
| </x-rapidez::slideover.mobile.header> | ||
| <x-rapidez::slideover.mobile.content> | ||
| Content | ||
| </x-rapidez::slideover.mobile.content> | ||
| <x-rapidez::slideover.mobile.footer> | ||
| Footer | ||
| </x-rapidez::slideover.mobile.footer> | ||
| </x-rapidez::slideover.mobile> | ||
| ``` | ||
| --}} | ||
|
|
||
| <x-rapidez::slideover :attributes="$attributes->twMerge('lg:contents')"> | ||
| {{ $slot }} | ||
| </x-rapidez::slideover> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is missing an example of the popover, these are all dialog slideovers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually it's exactly the same (same component same styling), within the <x-slideover component i've added simple instructions on how you can use the attributes on your button to trigger it as a popover or dialog.
If others also agree I'll add it :)