Conversation
tabs-active defaulted to pure white, while light backgrounds get a near-opaque white active island, so on any light theme that doesn't set tabs-active the active tab's title and close button were invisible. Leave tabs-active unset by default and fall back to foreground, which the theme already pairs with its background. Fixes raphamorim#1778
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On light themes that don't set
tabs-active, the active tab's title and close button are invisible:tabs-activedefaults to pure white, whileisland_fills()paints the active island near-opaque white whenever the background is light. This makestabs-activeoptional and falls back toforeground, which every theme already pairs with its background, so the title stays readable on both dark and light islands. Explicittabs-activevalues are unchanged. Fixes #1778.Colors::tabs_activeis nowOption<ColorArray>, resolved viaColors::tabs_active_or_foreground()defaults::tabs_active()foregrounddefault