Conversation
Contributor
|
@aeltai Thank you for the contribution. May you please sign the commit? |
Allow configuring CAPIProvider.spec.deployment.replicas (and optional scheduling fields) for the core cluster-api provider so capi-controller-manager can run with multiple replicas for HA. Fixes rancher#2812 Signed-off-by: Ala Eddin Eltai <ala.eltai@suse.com>
aeltai
force-pushed
the
feat/core-capi-replicas
branch
from
September 10, 2026 13:17
9dbaf88 to
9c7032d
Compare
Author
|
Signed the commit with GPG — thanks @anmazzotti. |
anmazzotti
approved these changes
Sep 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cluster-api-operator.cluster-api.core.replicasin the Turtles Helm chart so the coreCAPIProvidersetsspec.deployment.replicasforcapi-controller-manager.nodeSelector,tolerations, andaffinitytoCAPIProvider.spec.deployment.replicas: 1(no behavior change for existing installs beyond explicitly setting the existing API default).Fixes #2812
Test plan
helm templatewith default values rendersdeployment.replicas: 1on the coreCAPIProviderhelm template --set cluster-api-operator.cluster-api.core.replicas=2rendersreplicas: 2replicas=2results incapi-controller-managerDeployment with 2 ready pods and a single leader