Evaluate applied-checksum after setting needApplied flag - #126
Open
anmazzotti wants to merge 2 commits into
Open
anmazzotti wants to merge 2 commits into
anmazzotti wants to merge 2 commits into
Conversation
anmazzotti
requested review from
HarrisonWAffel,
Oats87,
aiyengar2 and
jakefhyde
as code owners
September 21, 2023 13:14
Author
|
@davidcassany FYI |
Contributor
|
This is actually intentional behavior. The purpose for this is to force apply a plan if the system-agent is restarted or the node is rebooted. I would be open to making this configurable; however, as we don't consider this behavior a bug, changing its default behavior is not acceptable |
Author
|
Thank you @Oats87 Since the flag is false by default this should not impact the current logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are running into some issues when the system-agent tries to re-apply remote plans that have been already applied.
This happens whenever the system-agent is restarted or the entire host is rebooted.
Some logic is already there to suppress re-execution based on secret resource version:
However the
w.lastAppliedResourceVersionis an in-memory value and a service restart will blank it again.Therefore evaluating the
applied-checksumis a more reliable way for remote plans.