docs(natspec): correct stale calculateClearStateChange cap description#2785
docs(natspec): correct stale calculateClearStateChange cap description#2785thedavidmeister wants to merge 4 commits into
Conversation
The previous prose described the old 'counterparty_IO * counterparty_outputMax' formula. The actual cap logic: each order's output is capped by the counterparty's max output (with input back-derived from the IO ratio). Refs #2671
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the NatSpec comment above ChangesRaindexV6 clear-state comment update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude <noreply@anthropic.com>
Summary
Corrects the stale calculateClearStateChange function-level NatSpec in RaindexV6.sol. The old prose described an obsolete formula (counterparty IO * counterparty_outputMax) inherited from a legacy OrderBook. The actual cap logic (correctly documented in the @dev on calculateClearStateAlice) caps each order's output via the counterparty's max output, with input back-derived from the IO ratio.
No bytecode change — this is a /// comment only.
Refs #2671 (partial: items 1-3 require code changes; items 5-6 are in upstream packages)
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Summary by CodeRabbit