Skip to content

Minimize Alloy features for sqlite-web consumers#247

Open
findolor wants to merge 1 commit into
mainfrom
sqlite-web-alloy-feature-minimal
Open

Minimize Alloy features for sqlite-web consumers#247
findolor wants to merge 1 commit into
mainfrom
sqlite-web-alloy-feature-minimal

Conversation

@findolor

@findolor findolor commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Disable Alloy default features for the float crate and workspace dependency.
  • Keep only the ABI/sol-types JSON features needed by the Rust bindings.
  • Avoid pulling Alloy provider/RPC/consensus crates that conflict with the Revm 36 dependency graph used by sqlite-web.
  • Commit the resulting lockfile/static formatting updates required by CI.

Test plan

  • cargo check -p rain-math-float
  • cargo fmt --all -- --check
  • nix develop -c rainix-rs-static
  • GitHub rs-static / rs-static
  • Verified from sqlite-web against this submodule commit (1586a5973882b6acb72c2677c29ad23c4c6f85ef):
    • cargo check --tests -p sqlite-web-core
    • cargo check --tests -p sqlite-web
    • nix develop -c build-submodules
    • prior full sqlite-web transaction validation listed in sqlite-web#28

Notes

  • GitHub rainix-sol / test / test is still failing on production deployment assertions that are also failing on recent main runs.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The PR updates alloy feature flags in the workspace manifest and in crates/float for both normal and dev dependencies. It disables default features and replaces json-rpc with json and json-abi.

Changes

Alloy dependency feature changes

Layer / File(s) Summary
Manifest feature flags
Cargo.toml, crates/float/Cargo.toml
The alloy workspace dependency and the crates/float dependency entries switch to default-features = false and enable json and json-abi instead of json-rpc; the crate’s dev-dependency entry is updated the same way.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: reducing Alloy features for sqlite-web consumers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sqlite-web-alloy-feature-minimal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@findolor findolor self-assigned this Jun 26, 2026
@findolor findolor changed the title Minimize alloy features for sqlite-web consumers Minimize Alloy features for sqlite-web consumers Jun 26, 2026
@findolor findolor force-pushed the sqlite-web-alloy-feature-minimal branch from 93f5845 to 1586a59 Compare June 26, 2026 10:14
@findolor findolor requested review from 0xgleb and JuaniRios June 26, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants