move BadMinStackLength to ErrFlow.sol#454
Conversation
Every other error reverted from Flow.sol is declared in a dedicated error file (ErrFlow.sol or rain.factory's ICloneableV2.sol). BadMinStackLength was the only outlier. Moving it to ErrFlow.sol lets consumers (interfaces, ABI bindings, integrators) get the selector without importing the concrete Flow contract and its OZ Multicall / ReentrancyGuard / interpreter dependencies. Closes #414. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 22 minutes and 41 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…badminstacklength-relocate
forge fmt wants the four-name ErrFlow import on a single line (fits in 120 chars) now that BadMinStackLength lives in ErrFlow.sol. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviewed f620f77: moves BadMinStackLength to ErrFlow.sol, rebased onto green main; CI green. LGTM. |
Summary
Every other error reverted from
Flow.solis declared in a dedicated error file (ErrFlow.solorrain.factory'sICloneableV2.sol).BadMinStackLengthwas the only outlier — declared inline in the implementation file.Moved to
src/error/ErrFlow.solso consumers (interfaces, ABI bindings, integrators) can get the selector without importing the concreteFlowcontract and its OZMulticall/ReentrancyGuard/ interpreter dependencies.Closes #414.
Test plan
forge buildclean🤖 Generated with Claude Code