Skip to content

move BadMinStackLength to ErrFlow.sol#454

Merged
thedavidmeister merged 3 commits into
mainfrom
2026-05-06-issue-414-badminstacklength-relocate
Jun 15, 2026
Merged

move BadMinStackLength to ErrFlow.sol#454
thedavidmeister merged 3 commits into
mainfrom
2026-05-06-issue-414-badminstacklength-relocate

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Summary

Every other error reverted from Flow.sol is declared in a dedicated error file (ErrFlow.sol or rain.factory's ICloneableV2.sol). BadMinStackLength was the only outlier — declared inline in the implementation file.

Moved to src/error/ErrFlow.sol so consumers (interfaces, ABI bindings, integrators) can get the selector without importing the concrete Flow contract and its OZ Multicall / ReentrancyGuard / interpreter dependencies.

Closes #414.

Test plan

  • forge build clean

🤖 Generated with Claude Code

Every other error reverted from Flow.sol is declared in a dedicated
error file (ErrFlow.sol or rain.factory's ICloneableV2.sol).
BadMinStackLength was the only outlier. Moving it to ErrFlow.sol lets
consumers (interfaces, ABI bindings, integrators) get the selector
without importing the concrete Flow contract and its OZ Multicall /
ReentrancyGuard / interpreter dependencies.

Closes #414.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 22 minutes and 41 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bcd76caa-6c52-47da-8e27-89b84411e284

📥 Commits

Reviewing files that changed from the base of the PR and between 28d5e67 and f620f77.

📒 Files selected for processing (2)
  • src/concrete/Flow.sol
  • src/error/ErrFlow.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-06-issue-414-badminstacklength-relocate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister self-assigned this May 9, 2026
@thedavidmeister

Copy link
Copy Markdown
Contributor Author

Reviewed 492aee7: moves BadMinStackLength from Flow.sol to ErrFlow.sol; rebased onto green main (post #476). Approved — merging on green CI.

forge fmt wants the four-name ErrFlow import on a single line (fits in 120
chars) now that BadMinStackLength lives in ErrFlow.sol.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister

Copy link
Copy Markdown
Contributor Author

Reviewed f620f77: moves BadMinStackLength to ErrFlow.sol, rebased onto green main; CI green. LGTM.

@thedavidmeister thedavidmeister merged commit 4e12f41 into main Jun 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A01-9] [LOW] BadMinStackLength declared in Flow.sol instead of ErrFlow.sol

1 participant