Repository navigation
feat(drift): watch the Rust crate pins in the weekly drift check (#118) - #163
Merged
Merged
Conversation
scripts/drift_check.py now reads the marked Cargo.toml block in the Rust section of instrumentation-gen.md and reports each crate against crates.io. The comparison follows Cargo's caret rules: 0.33 is not behind 0.33.9, but is behind 0.34. A BEHIND report says the crates move as a group, because a partial bump does not compile. tests/drift-check.test.sh checks the parser, the comparison, that the golden crate's Cargo.toml carries the same pins, and the documented group invariant: opentelemetry* share a minor and tracing-opentelemetry is exactly one ahead. Both mutations of that invariant were confirmed to fail the test.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Rust crates to the weekly drift check. Follow-up to #162 (part of #118).
What changed
scripts/drift_check.pyreads the markedCargo.tomlblock ininstrumentation-gen.md(the single source of the Rust pins) and reports each crate against crates.iobehind_compatiblefollows Cargo's caret rules, so0.33is not behind0.33.9but is behind0.34Cargo.lockneeds regeneratingtests/drift-check.test.shchecks the parser, the comparison, that the golden crate'sCargo.tomlmatches the pins, and the group rule (opentelemetry*share a minor,tracing-opentelemetryis one ahead)Test plan
bash tests/drift-check.test.shpasses, and so do all the other hook and snapshot testsTeeth: bumping
tracing-opentelemetryback to 0.33, and separately downgradingopentelemetry-otlpto 0.32, each fail the testRan
python3 scripts/drift_check.pyagainst crates.io: all 8 crates current, no false BEHIND ontracing 0.1.44ortracing-subscriber 0.3.23No version bump: only a script, a test and ROADMAP.md changed
Vendor, SDK and semantic-convention facts were verified against the source, not recalled — linked where it isn't obvious.
Nothing hardcoded that has a single source of truth (
SEMCONV_VERSION,backends.txt,hooks/otel-paths.sh).