Repository navigation
ci: gate chart version bumps and helm-docs freshness, report on the PR - #20
Merged
Merged
Conversation
Helm chart checks passedEarlier findings on this PR are resolved. |
kylecrawshaw
force-pushed
the
ci/helm-chart-checks
branch
from
August 31, 2026 21:10
669459e to
5d614ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
helmjob toci.yamlwith two checks, both reported as a sticky comment on the PR:charts/*/directory changed relative to the merge-base with the PR base branch,version:in that chart'sChart.yamlmust differ from the base. New charts pass automatically.workflow_call): regenerates docs with helm-docs pinned at v1.14.2 and fails if anycharts/*/README.mdchanges, printing the diff and pointing atmake helm-docs.Findings land in a single marker-identified PR comment that is updated in place on later pushes (no comment stacking) and flips to "checks passed" once fixed. If the job fails for infrastructure reasons with no findings, an existing comment is left untouched. On fork PRs the token is read-only, so the comment degrades to a log warning and the job failure alone carries the news.
pull-requests: writeis scoped to this job only.Why the chart changed too
The check surfaced its own flake source on the first local run: the chart README's footer embedded the generating helm-docs version (
Autogenerated ... helm-docs v1.14.2), so any differently-built helm-docs (e.g. ago installbuild with no version metadata) regenerated a spurious footer diff. This drops theversionFootertemplate fromREADME.md.gotmplso output is deterministic across tool builds, regenerates the README, and bumps the chart to0.2.1— as the new check itself requires for any chart directory change.Testing
origin/mainboth ways: passes with the0.2.1bump, correctly flags the chart when the version is reverted to0.2.0.🤖 Generated with Claude Code