Repository navigation
Conversation
yosangwon
force-pushed
the
bye-create-additions
branch
from
October 26, 2026 11:35
8162dc3 to
926c951
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201
It doesn't use
create_additionsat all, so we can just pull these options out and explicitly addjson > 3.0to the gemspec.As this gem only calls
JSONwith.parse, so I took thejson > 3.0instead ofjson ~> 3.0. (I wish there wouldn't be a breaking changes onJSON.parse.)minimum ruby version for
rackgem is now>= 2.7.3andjsonrequires> 2.7so I thought it's okay to add dependency and update contribute guideline.It looked like test cases have been failing since Ruby 3.4 with
Hash#inspectchanges, so I did some changes on test cases as well.