Ignore deleted entrants when recording races (Option 2 of 2) - #238
Open
TCKLZ wants to merge 2 commits into
Open
Conversation
deains
requested changes
Jun 28, 2026
deains
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! We do need to account for a couple of extra cases to make this work though.
- If the race is a team race, the guard should remain in place. Recording a team race with one or more deleted users will lead to imbalanced teams and that will skew the points awfully.
- If the race has only one entrant left after accounting for deleted users, it should not be recorded. A race with a single entrant cannot be meaningfully scored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rate_race()does not dereference a null user.Testing
python manage.py checkpython manage.py test racetime(0 tests found)python -m py_compile racetime/models/race.py racetime/rating.pyNote
This changes scoring behavior: deleted entrants are ignored for rating purposes, so points are calculated from the remaining users.
Commit 2; Updated to keep the deleted-user guard for team races, since ignoring a deleted entrant there could imbalance teams and skew ratings.
Also added a check so non-team races are only recorded if at least two entrants with accounts remain after deleted users are ignored.