Refactor OAuth views and remove PKCE workaround for LiveSplit - #231
Open
john-s-morgan wants to merge 1 commit into
Open
Refactor OAuth views and remove PKCE workaround for LiveSplit#231john-s-morgan wants to merge 1 commit into
john-s-morgan wants to merge 1 commit into
Conversation
john-s-morgan
marked this pull request as ready for review
January 5, 2026 13:45
Author
|
Friendly ping.. is anything blocking this? |
Route oauth2_authorize directly to the library's AuthorizationView and drop the OAuthAuthorize override (plus its now-unused imports). The LiveSplit client fix that necessitated the workaround was merged in December, so the standard OAuth2 authorization code flow (with PKCE) can now be used. Closes racetimeGG#191
john-s-morgan
force-pushed
the
bugfix/191-remove-pkce-workaround
branch
from
July 10, 2026 20:21
e44d6bd to
f7f75d6
Compare
Author
|
Looked at it again and removed the extra iSort churn. That came in thru format on save |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191
This removes the LiveSplit-specific PKCE override so the standard OAuth2 authorization code flow (with PKCE) can be used once client support is in place.
the fix I pushed for livesplit merged in December.