Skip to content

fix: Improve command injection surface extraction to catch simple variable args - #162

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix/command-injection-variable-args-1843738129770245306
Open

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix/command-injection-variable-args-1843738129770245306

Conversation

@google-labs-jules

Copy link
Copy Markdown

This PR improves the command-injection extraction by identifying that command execution functions (like os.system, child_process.exec, etc.) called with a single variable argument (e.g., exec(cmd)) are dangerous and were being missed. The regex has been updated to detect this pattern (\s*[a-zA-Z_]\w*\s* inside the arguments), preventing literals (like os.system('ls')) from being flagged as false positives. In addition, the grouping of the existing regex was corrected to fix a subtle bug where the |shell=True rule had improper global precedence.

It introduces no new runtime dependencies and fully passes tests and docguard guard.


PR created automatically by Jules for task 1843738129770245306 started by @raccioly

@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the needs-human Bot PR held for human review by the merge gate label Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Held for human review.

touches src/websec_validator/extractors/surface.py (protected path)

CI is green; the merge gate stops here on scope, not on test results. Merge it yourself if the change is what you want.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human Bot PR held for human review by the merge gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants