Skip to content

Close audit backlog - #62

Merged
malcolmbarrett merged 47 commits into
mainfrom
close-audit-backlog
Sep 1, 2026
Merged

Close audit backlog#62
malcolmbarrett merged 47 commits into
mainfrom
close-audit-backlog

Conversation

@malcolmbarrett

@malcolmbarrett malcolmbarrett commented Aug 24, 2026

Copy link
Copy Markdown
Member

From Fable-identified issues

@malcolmbarrett
clear all jarl lint findings
a1aa900
@malcolmbarrett
remove dead exposure type validation helpers
fe01541
@malcolmbarrett
ignore braid config in package builds
f446b55
@malcolmbarrett
make the halfmoon snapshot helpers assert their class argument and re…
fded9fd 
…cord the real call
@malcolmbarrett
report the calling function when a column name argument is invalid
dd9fcb9
@malcolmbarrett
validate that .reference_level names a single group by value or whole…
5c19c5b 
…-number position
@malcolmbarrett
validate .weights with causalgenerics::is_causal_wt() so any causal w…
c13e0e3 
…eight object passes
@malcolmbarrett
drop the inherit.aes argument geom_vline() does not accept in plot_ba…
f8ad91a 
…lance()
@malcolmbarrett
quote psw as code in the NEWS entry for weight validation
9d1b184
@malcolmbarrett
declare the propensity dependency with an explicit import
1f638a0
@malcolmbarrett
fix the sign, reference mapping, and NA policy of the atomic balance …
158c343 
…functions
@malcolmbarrett
delegate categorical reference resolution to the shared group helper
d3bf7af
@malcolmbarrett
read a logical column as a 0/1 indicator in create_dummy_variables
4637c32
@malcolmbarrett
rework check_balance reference resolution, selection, and failure rep…
1dd6c56 
…orting
@malcolmbarrett
catch the snapshot helper class mismatch as the condition it signals
5c90b5c
@malcolmbarrett
correct the target populations and missing-value policy of bal_energy
1e75759
@malcolmbarrett
reuse the energy distance matrix across weight columns in check_balance
e5fa4fa
@malcolmbarrett
correct the weighted ROC AUC and align the model diagnostic entry points
0f1666a
@malcolmbarrett
resolve the calibration focal level and missing values at the entry p…
8f94e8f 
…oints
@malcolmbarrett
correct the reference group and missing value policy of bal_prognosti…
b9378fb 
…c_score
@malcolmbarrett
resolve the calibration focal level before the layer is split into pa…
ca07d54 
…nels
@malcolmbarrett
give zero and full event calibration bins a real confidence interval
174e72b
@malcolmbarrett
fix the weighted quantile definition and unify the QQ reference seman…
f91fe75 
…tics
@malcolmbarrett
reshape check_ess through internal column names so a method or weight…
aec522f 
… column cannot collide
@malcolmbarrett
give check_ess an na.rm argument and count only observations with a w…
b738efd 
…eight
@malcolmbarrett
give the group columns of an add_ess_header table with an overall col…
3bc0387 
…umn an additive denominator
@malcolmbarrett
assert that ess returns NaN for an empty weight vector
5596232
@malcolmbarrett
validate the weights in bal_ess so its errors name bal_ess and .weights
1d5c836
@malcolmbarrett
draw one ROC curve per group and validate the focal level
d535cc9
@malcolmbarrett
honor pad and n in the weighted ECDF and drop missing weights
7ad84b1
@malcolmbarrett
mirror every statistic the mirrored geoms compute
ff04962
@malcolmbarrett
count observed exposure levels in the mirror and residual plots
4387ea4
@malcolmbarrett
draw the balance threshold in the smd facet
93ac3fa
@malcolmbarrett
clear the spelling check, raise the testthat floor, and untrack Rplot…
eb4612b 
…s.pdf
@malcolmbarrett
document what the plot methods return and test the errors check_balan…
73b9290 
…ce raises
@malcolmbarrett
align weighted dcor with cobalt and tighten the check_balance and bal…
261d373 
…_energy arguments
@malcolmbarrett
give weighted_quantile() an na.rm argument and tighten the QQ and ESS…
71498a5 
… entry points
@malcolmbarrett
tighten the ROC, calibration, and prognostic score diagnostics
8c56d66
@malcolmbarrett
support a flipped ECDF orientation and make the geom failures explicit
2381306
@malcolmbarrett
record the release notes and re-knit the README
79e5917
@malcolmbarrett
declare MatchIt in Suggests so the README builds from declared depend…
1de64d9 
…encies
@malcolmbarrett
refuse empty data in check_balance() before the covariate selection runs
76e04ff
@malcolmbarrett
leave the theme to the user in plot_model_calibration() for calibrati…
b3c2458 
…on objects
@malcolmbarrett
read the source column when a QQ weight selection renames it
586dd7d
@malcolmbarrett
record the release notes for the audit residuals
64a0c32
@malcolmbarrett
speed up observed level lookup and weighted ECDF tie aggregation
54e4827
@malcolmbarrett
add jarl check workflow
aebf9af
@malcolmbarrett
malcolmbarrett merged commit 7930d7e into main Sep 1, 2026
10 checks passed
@malcolmbarrett
malcolmbarrett deleted the close-audit-backlog branch September 1, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@malcolmbarrett