Skip to content

fix(sidebar): adjust height and padding for sidebar elements #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qxcnm merged 2 commits into from
Oct 26, 2026
Merged

fix(sidebar): adjust height and padding for sidebar elements #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47018cd
fix(sidebar): adjust height and padding for sidebar elements to enhan…
Jack251970 Oct 25, 2026
f571244
test(sidebar): align compact-window assertion with brand height
qxcnm Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/src/components/layout/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ export function Sidebar() {
/>
<div
className={cn(
"flex h-[50px] shrink-0 items-center border-b border-border/55",
"flex h-16 shrink-0 items-center border-b border-border/55",
Comment thread
qxcnm marked this conversation as resolved.
isSidebarOpen ? "px-3.5" : "px-2 xl:px-2.5"
)}
>
Expand All @@ -238,8 +238,8 @@ export function Sidebar() {
title={brandTitle}
aria-label={brandTitle}
className={cn(
"flex h-auto w-full items-center gap-2.5 overflow-hidden rounded-md px-0 py-1.5 transition-colors hover:bg-primary/5 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary/40",
isSidebarOpen ? "justify-start text-left" : "justify-center"
"flex h-auto w-full items-center gap-2.5 overflow-hidden rounded-md py-1.5 transition-colors hover:bg-primary/5 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary/40",
isSidebarOpen ? "justify-start px-2 text-left" : "justify-center px-0"
)}
>
<div className="flex size-9 shrink-0 items-center justify-center overflow-hidden rounded-md border border-primary/20 bg-card text-primary">
Expand Down
2 changes: 1 addition & 1 deletion apps/tests/sidebar-performance.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ test("wide but short windows keep the complete sidebar discoverable", async () =

assert.match(source, /min-h-8[\s\S]*xl:min-h-9/);
assert.match(source, /min-h-0 flex-1 overflow-y-auto overscroll-contain py-2/);
assert.match(source, /flex h-\[50px\] shrink-0 items-center/);
assert.match(source, /flex h-16 shrink-0 items-center/);
});

test("page fallback stays aligned with both sidebar widths", async () => {
Expand Down
Loading