Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ pub(super) fn convert_success_body_for_adapter(
convert_anthropic_messages_body_to_responses(body)
}
ResponseAdapter::ChatCompletionsFromResponses => {
convert_responses_body_to_chat_completions(body)
convert_responses_body_to_chat_completions(body, tool_name_restore_map)
}
ResponseAdapter::CompactFromChatCompletions => {
convert_chat_completions_body_to_compact(body)
Expand Down Expand Up @@ -638,7 +638,10 @@ fn responses_usage_to_chat_usage(usage: &Value) -> Value {
mapped
}

pub(super) fn convert_responses_body_to_chat_completions(body: &[u8]) -> Option<Vec<u8>> {
pub(super) fn convert_responses_body_to_chat_completions(
body: &[u8],
tool_name_restore_map: Option<&ToolNameRestoreMap>,
) -> Option<Vec<u8>> {
let value = serde_json::from_slice::<Value>(body).ok()?;
let response = value.get("response").unwrap_or(&value);
let mut text = String::new();
Expand Down Expand Up @@ -690,6 +693,30 @@ pub(super) fn convert_responses_body_to_chat_completions(body: &[u8]) -> Option<
if let Some(usage) = usage {
completion["usage"] = usage;
}
let tool_calls: Vec<Value> = response
.get("output")
.and_then(Value::as_array)
.into_iter()
.flatten()
.filter(|item| item.get("type").and_then(Value::as_str) == Some("function_call"))
.map(|item| {
Some(json!({
"id": item.get("call_id").or_else(|| item.get("id"))?.as_str()?,
"type": "function",
"function": {
"name": restore_tool_name(item.get("name")?.as_str()?, tool_name_restore_map),
"arguments": item.get("arguments")?.as_str()?,
}
}))
})
.collect::<Option<Vec<_>>>()?;
if !tool_calls.is_empty() {
completion["choices"][0]["message"]["tool_calls"] = Value::Array(tool_calls);
completion["choices"][0]["finish_reason"] = Value::String("tool_calls".to_string());
if text.is_empty() {
completion["choices"][0]["message"]["content"] = Value::Null;
}
}
if !reasoning_text.trim().is_empty() {
completion["choices"][0]["message"]["reasoning"] = Value::String(reasoning_text.clone());
completion["choices"][0]["message"]["reasoning_content"] = Value::String(reasoning_text);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ fn non_stream_chat_completion_response_adds_image_generation_message_images() {

let mapped = convert_responses_body_to_chat_completions(
serde_json::to_vec(&body).expect("body").as_slice(),
None,
)
.expect("convert chat completion body");
let value: serde_json::Value = serde_json::from_slice(&mapped).expect("parse mapped body");
Expand Down Expand Up @@ -409,6 +410,7 @@ fn non_stream_chat_completion_response_preserves_reasoning_content() {

let mapped = convert_responses_body_to_chat_completions(
serde_json::to_vec(&body).expect("body").as_slice(),
None,
)
.expect("convert chat completion body");
let value: serde_json::Value = serde_json::from_slice(&mapped).expect("parse mapped body");
Expand Down Expand Up @@ -443,6 +445,7 @@ fn non_stream_chat_completion_response_preserves_answer_and_reasoning_content()

let mapped = convert_responses_body_to_chat_completions(
serde_json::to_vec(&body).expect("body").as_slice(),
None,
)
.expect("convert chat completion body");
let value: serde_json::Value = serde_json::from_slice(&mapped).expect("parse mapped body");
Expand All @@ -467,7 +470,7 @@ fn non_stream_chat_responses_sse_json_mode_returns_single_parseable_content() {
);
let (body, _) = collect_non_stream_json_from_sse_bytes(sse.as_bytes());
let body = body.expect("synthesized response json");
let mapped = convert_responses_body_to_chat_completions(body.as_slice())
let mapped = convert_responses_body_to_chat_completions(body.as_slice(), None)
.expect("convert chat completion body");
let value: serde_json::Value =
serde_json::from_slice(&mapped).expect("parse chat completion body");
Expand All @@ -481,6 +484,57 @@ fn non_stream_chat_responses_sse_json_mode_returns_single_parseable_content() {
assert_eq!(parsed["answer"], true);
}

#[test]
fn non_stream_chat_completion_preserves_parallel_tool_calls_and_restores_names() {
let names =
std::collections::BTreeMap::from([("safe_echo".to_string(), "echo.probe".to_string())]);
let body = json!({
"id": "resp_tools", "model": "gpt-6-astra", "output_text": "Checking.",
"output": [
{"type": "function_call", "id": "fc_1", "call_id": "call_1", "name": "safe_echo", "arguments": "{\"value\":\"hello\"}"},
{"type": "function_call", "id": "fc_2", "call_id": "call_2", "name": "second", "arguments": "{}"}
],
"usage": {"input_tokens": 10, "output_tokens": 5, "total_tokens": 15}
});
let mapped = convert_responses_body_to_chat_completions(
&serde_json::to_vec(&body).unwrap(),
Some(&names),
)
.unwrap();
let value: serde_json::Value = serde_json::from_slice(&mapped).unwrap();
let choice = &value["choices"][0];
assert_eq!(choice["finish_reason"], "tool_calls");
assert_eq!(choice["message"]["content"], "Checking.");
let calls = choice["message"]["tool_calls"].as_array().unwrap();
assert_eq!(calls.len(), 2);
assert_eq!(calls[0]["id"], "call_1");
assert_eq!(calls[0]["function"]["name"], "echo.probe");
assert_eq!(calls[0]["function"]["arguments"], "{\"value\":\"hello\"}");
assert_eq!(calls[1]["id"], "call_2");
assert_eq!(value["usage"]["prompt_tokens"], 10);
}

#[test]
fn non_stream_chat_responses_sse_preserves_tool_only_completion() {
let response = json!({"type": "response.completed", "response": {
"id": "resp_tool_only", "model": "gpt-6-astra", "status": "completed",
"output": [{"type": "function_call", "call_id": "call_echo", "name": "echo_probe", "arguments": "{\"value\":\"ok\"}"}]
}});
let sse = format!(
"event: response.completed\ndata: {}\n\ndata: [DONE]\n\n",
response
);
let (body, _) = collect_non_stream_json_from_sse_bytes(sse.as_bytes());
let mapped = convert_responses_body_to_chat_completions(&body.unwrap(), None).unwrap();
let value: serde_json::Value = serde_json::from_slice(&mapped).unwrap();
assert_eq!(value["choices"][0]["finish_reason"], "tool_calls");
assert!(value["choices"][0]["message"]["content"].is_null());
assert_eq!(
value["choices"][0]["message"]["tool_calls"][0]["id"],
"call_echo"
);
}

#[test]
fn sse_synthesized_body_usage_merge_does_not_duplicate_output_text() {
let sse = concat!(
Expand Down
Loading