Repository navigation
fix(responses): deliver native stream failures as response.failed - #502
Merged
qxcnm merged 2 commits intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The native
/v1/responsespassthrough reader can observe an upstream terminalerrorevent while forwarding it unchanged. Codex ignores most genericerrorevents and, on EOF, replaces the useful upstream message withstream closed before response.completed.After the upstream stream ends, emit a standard
response.failedSSE frame whenever the collector has a terminal error but no Responses terminal event was delivered. This also covers read errors, disconnects, and idle timeouts. Already deliveredresponse.failed,response.incomplete, andresponse.completedframes are not duplicated or changed.This preserves the original upstream error and makes it visible to the client; it does not change the upstream service failure itself. Related report: #501.
Tests
cargo test --locked -p codexmanager-service --lib openai_responses -- --test-threads=1(27 passed)cargo fmt --all -- --checkgit diff --checkpnpm -C apps run build:desktop